Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Remove] MainResponse version override cluster setting #3032

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport cf78065 from #3031

@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner April 21, 2022 21:17
@nknize nknize force-pushed the backport/backport-3031-to-2.x branch from 1182ea8 to 731a8e4 Compare April 21, 2022 21:29
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 1182ea82f9e0ea71126af2438eecb4234c97dc02
Log 4693

Reports 4693

@dblock
Copy link
Member

dblock commented Apr 21, 2022

@nknize 🔴

2022-04-21T21:34:01.4702763Z > Task :distribution:docker:forbiddenPatterns
2022-04-21T21:34:01.4703964Z         Version version = VersionUtils.randomVersionBetween(random(), LegacyESVersion.V_7_0_0, Version.CURRENT);
2022-04-21T21:34:01.4704557Z                                                                       ^
2022-04-21T21:34:01.4705059Z   symbol:   variable LegacyESVersion
2022-04-21T21:34:01.4705779Z   location: class MainResponseTests

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 731a8e480a87ae5ad2a0eec9810ee6f083d1882c
Log 4696

Reports 4696

With types removal OpenSearch 2.0.0 no longer supports HLRC compatibility
with legacy clients. This commit removes all 1.x logic to spoof the
version as a legacy cluster.

Signed-off-by: Nicholas Walter Knize <[email protected]>
(cherry picked from commit cf78065)
@nknize nknize force-pushed the backport/backport-3031-to-2.x branch from 9aacad1 to 34af611 Compare April 21, 2022 22:20
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 9aacad10dfda40bb30ff3dd7007a1220dd08677f
Log 4700

Reports 4700

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 34af611
Log 4701

Reports 4701

@nknize nknize merged commit 199fbb8 into 2.x Apr 21, 2022
@github-actions github-actions bot deleted the backport/backport-3031-to-2.x branch April 21, 2022 23:13
nknize added a commit to nknize/OpenSearch that referenced this pull request Jun 7, 2022
nknize added a commit that referenced this pull request Jun 8, 2022
nknize added a commit that referenced this pull request Jun 8, 2022
#3032)" (#3530)

This reverts commit 199fbb8.

Signed-off-by: Nicholas Walter Knize <[email protected]>
(cherry picked from commit 069948a)
nknize pushed a commit that referenced this pull request Jun 9, 2022
#3032)" (#3530) (#3536)

This reverts commit 199fbb8.

Signed-off-by: Nicholas Walter Knize <[email protected]>
(cherry picked from commit 069948a)
@AkM-2018 AkM-2018 mentioned this pull request May 14, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants