Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.0] Add request parameter 'cluster_manager_timeout' and deprecate 'master_timeout' - in Index APIs except index template APIs #2771

Merged
merged 1 commit into from
Apr 5, 2022
Merged

[Backport 2.0] Add request parameter 'cluster_manager_timeout' and deprecate 'master_timeout' - in Index APIs except index template APIs #2771

merged 1 commit into from
Apr 5, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 7aa496f from #2660

@github-actions
Add request parameter 'cluster_manager_timeout' and deprecate 'master…
ba0f9d5 
…_timeout' - in Index APIs except index template APIs (#2660)

- Deprecate the request parameter `master_timeout` that used in Index APIs which have got the parameter.
(except index template APIs, which is addressed in PR #2678)
- Add alternative new request parameter `cluster_manager_timeout`.
- Add unit tests.

Signed-off-by: Tianli Feng <[email protected]>
(cherry picked from commit 7aa496f)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner April 5, 2022 17:48
@tlfeng tlfeng added v2.0.0 Version 2.0.0 backport PRs or issues specific to backporting features or enhancments labels Apr 5, 2022
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure ba0f9d5
Log 4204

Reports 4204

@tlfeng
Copy link
Collaborator

tlfeng commented Apr 5, 2022 •
edited
Loading

In log 4204:

> Task :qa:remote-clusters:integTest

WARNING: A terminally deprecated method in java.lang.System has been called
REPRODUCE WITH: ./gradlew ':qa:remote-clusters:integTest' --tests "org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks" -Dtests.seed=FC64F5E79860A1C -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=uk-UA -Dtests.timezone=Antarctica/Troll -Druntime.java=17

org.opensearch.cluster.remote.test.RemoteClustersIT > testHAProxyModeConnectionWorks FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([FC64F5E79860A1C:8B09A9542007C41]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks(RemoteClustersIT.java:125)

It's reported in issue #1703. This test failure occurs together with #2770 (comment)
re-run: start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success ba0f9d5
Log 4212

Reports 4212

tlfeng
tlfeng approved these changes Apr 5, 2022
View reviewed changes
Copy link
Collaborator

@tlfeng tlfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kotwanikunal Thanks a lot for your review!

@tlfeng tlfeng merged commit e9bd78c into 2.0 Apr 5, 2022
@tlfeng tlfeng deleted the backport/backport-2660-to-2.0 branch April 5, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotwanikunal kotwanikunal kotwanikunal approved these changes

@tlfeng tlfeng tlfeng approved these changes

Assignees
No one assigned
Labels
backport PRs or issues specific to backporting features or enhancments v2.0.0 Version 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@opensearch-ci-bot @tlfeng @kotwanikunal