[Backport 2.0] Centralize codes related to 'master_timeout' deprecation for eaiser removal - in CAT Nodes API #2696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…emoval - in CAT Nodes API (#2670) * Move parseDeprecatedMasterTimeoutParameter method into BaseRestHandler class to reduce duplication Signed-off-by: Tianli Feng <[email protected]> * Add more comments to unit test Signed-off-by: Tianli Feng <[email protected]> * Make log message key different Signed-off-by: Tianli Feng <[email protected]> * Prohibit using 'master_timeout' and 'cluster_manager_timeout' parameter together Signed-off-by: Tianli Feng <[email protected]> * Add separate unit tests for BaseRestHandler.parseDeprecatedMasterTimeoutParameter() Signed-off-by: Tianli Feng <[email protected]> * Restore unit test for cat allocation api Signed-off-by: Tianli Feng <[email protected]> * Adjust format by spotlessApply task Signed-off-by: Tianli Feng <[email protected]> * Fix testBothParamsNotValid() by adding warning assertion Signed-off-by: Tianli Feng <[email protected]> (cherry picked from commit e1ee222)
tlfeng
added
enhancement
mch2
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport e1ee222 from #2670