Exclude man page symlink in distribution #2602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a short-term solution to unblock the build process for the 1.3 release. A tool used in that process (cpio) is failing on a symlink in the JDK man pages, so this is a hack to just remove that symlink. See issue opensearch-project#2517 for more details. Signed-off-by: Andrew Ross <[email protected]>
xuezhou25
approved these changes
Mar 25, 2022
|
Manual testing done: |
anasalkouz
approved these changes
Mar 25, 2022
|
Seems like WS stuck on the runs, takes significantly longer time and still running. |
peterzhuamazon
pushed a commit
to peterzhuamazon/OpenSearch
that referenced
this pull request
Mar 26, 2022
This is a short-term solution to unblock the build process for the 1.3 release. A tool used in that process (cpio) is failing on a symlink in the JDK man pages, so this is a hack to just remove that symlink. See issue opensearch-project#2517 for more details. Signed-off-by: Andrew Ross <[email protected]>
|
@andrross We also need this on |
|
@dblock As long as we continue using JDK 17 with the newer versions of OpenSearch then we don't need to backport because that JDK doesn't include the problematic symlink. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a short-term solution to unblock the build process for the 1.3
release. A tool used in that process (cpio) is failing on a symlink in
the JDK man pages, so this is a hack to just remove that symlink. See
issue #2517 for more details.
Signed-off-by: Andrew Ross [email protected]
Issues Resolved
#2517
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.