Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Support first and last parameter for missing bucket ordering … #2145

Closed
wants to merge 1 commit into from

Conversation

andrross
Copy link
Member

…in composite aggregation (#1942) (#2049)"

This reverts commit 5b27136.

Signed-off-by: Andrew Ross [email protected]

Description

Reverts a commit that appears to be breaking backward compatibility tests. Exact cause is not known, but this revert should unblock the builds.

Issues Resolved

closes #2143

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 42cc5f0
Log 2471

Reports 2471

@andrross
Copy link
Member Author

Error downloading centos caused build failure.

@andrross
Copy link
Member Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 42cc5f0
Log 2474

Reports 2474

@dblock
Copy link
Member

dblock commented Feb 17, 2022

start gradle check

@andrross
Copy link
Member Author

#2147 should be the fix for this issue on the main branch. Assuming that PR works as expected and is merged, then this PR will be closed.

@nknize
Copy link
Collaborator

nknize commented Feb 17, 2022

Assuming that PR works as expected and is merged, then this PR will be closed.

agree... it should do the trick. Composite Agg transport failures are triggering bwc failures on multiple PRs so #2147 is high priority

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 42cc5f0
Log 2503

Reports 2503

@andrross
Copy link
Member Author

Closing now that #2147 has been merged.

@andrross andrross closed this Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants