Add Task Id in thread context for Transport and Rest requests #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 11, 2022 20:41
Signed-off-by: Tushar Kharbanda <[email protected]>
Signed-off-by: Tushar Kharbanda <[email protected]>
Signed-off-by: Tushar Kharbanda <[email protected]>
Signed-off-by: Tushar Kharbanda <[email protected]>
Signed-off-by: Tushar Kharbanda <[email protected]>
Signed-off-by: Tushar Kharbanda <[email protected]>
|
Can one of the admins verify this patch? |
Bukhtawar
reviewed
Jan 12, 2022
Comment on lines
+454
to
+480
| /** | ||
| * Adds Task Id in the ThreadContext. | ||
| * | ||
| * Stashes the existing ThreadContext and preserves all the existing ThreadContext's data in the new ThreadContext | ||
| * as well. | ||
| * | ||
| * @param task for which Task Id needs to be added in ThreadContext. | ||
| * | ||
| * @return StoredContext reference to restore the ThreadContext from which we created a new one. | ||
| * Caller can call context.restore() to get the existing ThreadContext back. | ||
| */ | ||
| public ThreadContext.StoredContext addTaskIdInThreadContext(@Nullable Task task) { | ||
| if (task == null) { | ||
| return () -> {}; | ||
| } | ||
|
|
||
| ThreadContext threadContext = threadPool.getThreadContext(); | ||
|
|
||
| if (threadContext.getTransient(TASK_ID) != null) { | ||
| logger.warn("Task Id already present in the thread context. Overwriting"); | ||
| } | ||
|
|
||
| ThreadContext.StoredContext storedContext = threadContext.newStoredContext(true, Collections.singletonList(TASK_ID)); | ||
| threadContext.putTransient(TASK_ID, task.getId()); | ||
| return storedContext; | ||
| } | ||
|
|
There was a problem hiding this comment.
Lets think about placing this logic outside of the purview of the TaskManager
|
@tushar-kharbanda72 This is a good feature, want to finish it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is to include Task Id in thread context for all the Rest or Transport requests. This change is required majorly to implement task resource tracking which relies on the fact that Task Id will be available in Thread Context.
Issues Resolved
#1179
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.