Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remove] DynamicTemplate deprecations #1742

Merged
merged 2 commits into from
Dec 16, 2021
Merged

[Remove] DynamicTemplate deprecations #1742

merged 2 commits into from
Dec 16, 2021

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Dec 16, 2021 •
edited
Loading

This PR removes legacy version checks in DynamicTemplate parsing that are no longer valid in OpenSearch 2.0.0.

@nknize nknize added v2.0.0 Version 2.0.0 non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues labels Dec 16, 2021
@nknize nknize requested a review from a team as a code owner December 16, 2021 05:03
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@nknize
[Remove] DynamicTemplate deprecations
1d5962e 
This commit removes legacy version checks in DynamicTemplate parsing that are no
longer valid in OpenSearch 2.0.0.

Signed-off-by: Nicholas Walter Knize <[email protected]>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 7bfba81a1791a841d87ff8bb419c7c0f30664fb2
Log 1522

Reports 1522

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 1d5962e
Log 1523

Reports 1523

@nknize
spotless
b3dae8b 
Signed-off-by: Nicholas Walter Knize <[email protected]>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure b3dae8b
Log 1527

Reports 1527

@nknize
Copy link
Collaborator Author

nknize commented Dec 16, 2021

Unrelated test failure ClusterHealthIT.testHealthOnMasterFailover.

Opened #1744

@nknize
Copy link
Collaborator Author

nknize commented Dec 16, 2021

start gradle check

@nknize nknize mentioned this pull request Dec 16, 2021
Closed
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure b3dae8b
Log 1529

Reports 1529

@nknize nknize mentioned this pull request Dec 16, 2021
Closed
@nknize
Copy link
Collaborator Author

nknize commented Dec 16, 2021

Another unrelated failure. Opened issue #1746 to track so we can address the problem instead of continuing to face these PR failures.

@nknize
Copy link
Collaborator Author

nknize commented Dec 16, 2021

start gradle check

adnapibar
adnapibar approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@adnapibar adnapibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success b3dae8b
Log 1537

Reports 1537

@nknize nknize merged commit ef44182 into opensearch-project:main Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adnapibar adnapibar adnapibar approved these changes

Assignees
No one assigned
Labels
non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues v2.0.0 Version 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nknize @opensearch-ci-bot @adnapibar