Introduce Template query #16818
Open
Introduce Template query #16818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingshl
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah,
jainankitk and
linuxpi
as code owners
|
❌ Gradle check result for ff1acc0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
mingshl
force-pushed
the
template-query
branch
from
a159416 to
cf97416
Compare
|
updated |
|
❌ Gradle check result for cf97416: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@mingshl I sadly cannot do it (not a maintainers on |
|
❌ Gradle check result for c3c31aa: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
mingshl
force-pushed
the
template-query
branch
from
c3c31aa to
2bea56e
Compare
Make QueryRewriteContext an interface. Rename existing impl to BaseQueryRewriteContext. Create coordinator-level context called QueryCoordinatorContext. It can expose pipelined search request, including PipelineProcessingContext to rewrite methods. Signed-off-by: Mingshi Liu <[email protected]>
Introduce template query that holds the content of query which can contain placeholders and can be filled by the variables from PipelineProcessingContext produced by search processors. This allows query rewrite by the search processors. Signed-off-by: Mingshi Liu <[email protected]>
Signed-off-by: Mingshi Liu <[email protected]> Add changelog Signed-off-by: Mingshi Liu <[email protected]>
Signed-off-by: Prudhvi Godithi <[email protected]> Signed-off-by: Mingshi Liu <[email protected]>
…Service is not in sync with cluster-state (opensearch-project#16763) * Skip remote-repositories validations for node-joins when RepositoriesService is not in sync with cluster-state Signed-off-by: Pranshu Shukla <[email protected]> Signed-off-by: Mingshi Liu <[email protected]>
Signed-off-by: Brandon Shien <[email protected]> Signed-off-by: Mingshi Liu <[email protected]>
…/hdfs-fixture (opensearch-project#16807) * Bump com.nimbusds:nimbus-jose-jwt in /test/fixtures/hdfs-fixture Bumps [com.nimbusds:nimbus-jose-jwt](https://bitbucket.org/connect2id/nimbus-jose-jwt) from 9.46 to 9.47. - [Changelog](https://bitbucket.org/connect2id/nimbus-jose-jwt/src/master/CHANGELOG.txt) - [Commits](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.47..9.46) --- updated-dependencies: - dependency-name: com.nimbusds:nimbus-jose-jwt dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: Mingshi Liu <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Mingshi Liu <[email protected]>
* Fixing _list/shards API for closed indices Signed-off-by: Harsh Garg <[email protected]> Signed-off-by: Mingshi Liu <[email protected]>
…roject#16678) * Added implementation for the stats calculation for search and regular replica in shards Signed-off-by: Vinay Krishna Pudyodu <[email protected]> * Updated changelog Signed-off-by: Vinay Krishna Pudyodu <[email protected]> * Added unit tests for TransportSegmentReplicationStatsAction Signed-off-by: Vinay Krishna Pudyodu <[email protected]> * fixed java style after running precommit locally Signed-off-by: Vinay Krishna Pudyodu <[email protected]> * refined the test cases Signed-off-by: Vinay Krishna Pudyodu <[email protected]> * fixed style issues Signed-off-by: Vinay Krishna Pudyodu <[email protected]> * Made changes in the bytes to download calculation based on comments Signed-off-by: Vinay Krishna Pudyodu <[email protected]> * added addReplicaStats method to SegmentReplicationPerGroupStats Signed-off-by: Vinay Krishna Pudyodu <[email protected]> * fixed style issues Signed-off-by: Vinay Krishna Pudyodu <[email protected]> * Fixed issue with immutable set Signed-off-by: Vinay Krishna Pudyodu <[email protected]> * Fixed PR comments and moved the integration tests to separate module Signed-off-by: Vinay Krishna Pudyodu <[email protected]> * Fixed failing integ tests Signed-off-by: Vinay Krishna Pudyodu <[email protected]> * Fixed failing integ test Signed-off-by: Vinay Krishna Pudyodu <[email protected]> * fixed some comments for PR Signed-off-by: Vinay Krishna Pudyodu <[email protected]> * fixed failing tests Signed-off-by: Vinay Krishna Pudyodu <[email protected]> --------- Signed-off-by: Vinay Krishna Pudyodu <[email protected]> remove license Signed-off-by: Mingshi Liu <[email protected]>
mingshl
force-pushed
the
template-query
branch
from
2bea56e to
4555938
Compare
|
❌ Gradle check result for 4555938: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request introduces the following key enhancements:
1. New 'Template' Query Type:
Implements a new query type that holds an object of query content.
Supports placeholders within the query content.
Passes the query content to search request processing.
2. Query Rewrite Context Refactoring:
Query Rewrite Context now carries the pipelineContext variables after all search request processors processed.
Template queries resolve placeholders during query rewrites.
Inner queries are constructed dynamically based on resolved placeholders.
Related Issues
#16823
opensearch-project/ml-commons#3054
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.