Revert "Support Gradle 7 (#1609) (#1622)" #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
✅ Gradle Wrapper Validation success 17ae3616e53136046f91853eeb666598cdeb2dd2 |
|
✅ Gradle Precommit success 17ae3616e53136046f91853eeb666598cdeb2dd2 |
|
❌ Gradle Check failure 17ae3616e53136046f91853eeb666598cdeb2dd2 |
…t#1622)" This reverts commit 93bd32b. Signed-off-by: Andriy Redko <[email protected]>
reta
force-pushed
the
issue-1246.1.x.revert
branch
from
17ae361 to
3781516
Compare
|
✅ Gradle Wrapper Validation success 3781516 |
|
@dlvenable fyi, the 1.x+ would stay on Gradle 6. |
|
✅ Gradle Precommit success 3781516 |
|
@dblock good to go, the WhiteSource seems to be known issue, thank you! |
dblock
approved these changes
Dec 6, 2021
|
Thank you! |
This was referenced Dec 6, 2021
Closed
peternied
added a commit
to peternied/security
that referenced
this pull request
Mar 2, 2022
BWC tooling is built with gradle 6, which has breaking changes that are not compatiable with gradle 7. In order to support BWC tests we need to align with the OpenSearch's gradle version for the 1.3 release. See Also: * Gradle 7 PR in OpenSearch opensearch-project/OpenSearch#1622 * Distribution build bugs encountered by plugins opensearch-project/opensearch-build#1247 * Revert of Gradle 7 PR in OpenSearch opensearch-project/OpenSearch#1657 Signed-off-by: Peter Nied <[email protected]>
3 tasks
peternied
added a commit
to opensearch-project/security
that referenced
this pull request
Mar 15, 2022
* Downgrade gradle version BWC tooling is built with gradle 6, which has breaking changes that are not compatiable with gradle 7. In order to support BWC tests we need to align with the OpenSearch's gradle version for the 1.3 release. See Also: * Gradle 7 PR in OpenSearch opensearch-project/OpenSearch#1622 * Distribution build bugs encountered by plugins opensearch-project/opensearch-build#1247 * Revert of Gradle 7 PR in OpenSearch opensearch-project/OpenSearch#1657 Signed-off-by: Peter Nied <[email protected]>
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
* Downgrade gradle version BWC tooling is built with gradle 6, which has breaking changes that are not compatiable with gradle 7. In order to support BWC tests we need to align with the OpenSearch's gradle version for the 1.3 release. See Also: * Gradle 7 PR in OpenSearch opensearch-project/OpenSearch#1622 * Distribution build bugs encountered by plugins opensearch-project/opensearch-build#1247 * Revert of Gradle 7 PR in OpenSearch opensearch-project/OpenSearch#1657 Signed-off-by: Peter Nied <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Redko [email protected]
Description
As per discussion opensearch-project/opensearch-build#1247, the decision was taken to keep 1.x on Gradle 6.x in order to not disrupt the plugin developers.
Issues Resolved
opensearch-project/opensearch-build#1247
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.