Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version check in yaml test file for the bug fix for get index settings API #16480

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

gaobinlong
Copy link
Collaborator

Description

After this PR is backported to 2.x branch, we need to correct the version check in the yaml test file.

Change los and backport 2.x are not needed.

Related Issues

No issue.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

✅ Gradle check result for 5d3936e: SUCCESS

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.91%. Comparing base (4ad1be3) to head (5d3936e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16480      +/-   ##
============================================
- Coverage     72.03%   71.91%   -0.12%     
+ Complexity    65003    64945      -58     
============================================
  Files          5313     5313              
  Lines        303375   303375              
  Branches      43902    43902              
============================================
- Hits         218544   218181     -363     
- Misses        66915    67277     +362     
- Partials      17916    17917       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta
Copy link
Collaborator

reta commented Oct 25, 2024

Thanks @gaobinlong , sorry about that, I forgot to send the forwardport

@reta reta merged commit b2d537a into opensearch-project:main Oct 25, 2024
67 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants