Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add log message if SSL dual mode is enabled #16437

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Add log message if SSL dual mode is enabled #16437

merged 2 commits into from
Oct 23, 2024

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Oct 22, 2024

Description

Small PR to add a logline back in that was inadvertently removed in #16387

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for b524957: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.05%. Comparing base (5120efb) to head (b524957).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...ch/transport/netty4/ssl/SecureNetty4Transport.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #16437      +/-   ##
============================================
+ Coverage     72.03%   72.05%   +0.02%     
- Complexity    64998    65041      +43     
============================================
  Files          5313     5313              
  Lines        303293   303294       +1     
  Branches      43886    43886              
============================================
+ Hits         218476   218545      +69     
+ Misses        66863    66822      -41     
+ Partials      17954    17927      -27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dbwiddis
dbwiddis approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

  1. I'm approving but needs a changelog so may need reapproal
  2. why is @peternied the only approver tagged here for review?

@cwperks
Copy link
Member Author

cwperks commented Oct 23, 2024 •
edited
Loading

@dbwiddis wdyt about adding skip-changelog label to this PR? IMO changelog entry is not needed since there is already an entry for #16387. This PR is undoing an inadvertent removal of a logline w/ useful info.

FYI the reason why @peternied is the only maintainer tagged is because of this entry in the CODEOWNERS file: https://github.com/opensearch-project/OpenSearch/blob/main/.github/CODEOWNERS#L18

@dbwiddis
Copy link
Member

Sure, if it's all within the same release, no need to include every fine tuning.

@dbwiddis dbwiddis merged commit 8eccbb5 into opensearch-project:main Oct 23, 2024
41 of 43 checks passed
@dbwiddis dbwiddis added the backport 2.x Backport to 2.x branch label Oct 23, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 23, 2024
@github-actions
Add log message if SSL dual mode is enabled (#16437)
27eb977 
* Add log message about dual mode enabled

Signed-off-by: Craig Perkins <[email protected]>

* Add log message about dual mode enabled

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 8eccbb5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 23, 2024
Merged
dbwiddis pushed a commit that referenced this pull request Oct 23, 2024
@opensearch-trigger-bot @github-actions
Add log message if SSL dual mode is enabled (#16437) (#16457)
56551fd 
* Add log message about dual mode enabled



* Add log message about dual mode enabled



---------


(cherry picked from commit 8eccbb5)

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbwiddis dbwiddis dbwiddis approved these changes

@peternied peternied Awaiting requested review from peternied peternied is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwperks @dbwiddis