[Snapshot V2] Move timestamp pinning before cluster state update #16269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbafna
changed the title
sachinpkale
reviewed
Oct 10, 2024
server/src/main/java/org/opensearch/snapshots/SnapshotsService.java
Outdated
Show resolved
Hide resolved
|
❌ Gradle check result for 0089d64: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This was referenced Oct 10, 2024
gbbafna
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❌ Gradle check result for 5d14a37: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Not able to repro in local. Re-triggering the build |
|
❌ Gradle check result for 5d14a37: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gaurav Bafna <[email protected]>
Signed-off-by: Gaurav Bafna <[email protected]>
Signed-off-by: Gaurav Bafna <[email protected]>
gbbafna
force-pushed
the
early-pinned-time
branch
from
87ca7d4
to
25096ca
Compare
|
❌ Gradle check result for 25096ca: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16269 +/- ##
============================================
- Coverage 72.00% 72.00% -0.01%
+ Complexity 64796 64743 -53
============================================
Files 5307 5307
Lines 302540 302541 +1
Branches 43708 43709 +1
============================================
- Hits 217853 217841 -12
+ Misses 66801 66799 -2
- Partials 17886 17901 +15 ☔ View full report in Codecov by Sentry. |
sachinpkale
approved these changes
Oct 14, 2024
This was referenced Oct 12, 2024
Open
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
) * Move timestamp pinning before cluster state update Signed-off-by: Gaurav Bafna <[email protected]> * Address PR Comments Signed-off-by: Gaurav Bafna <[email protected]> * Fix IT Signed-off-by: Gaurav Bafna <[email protected]> --------- Signed-off-by: Gaurav Bafna <[email protected]> (cherry picked from commit b5dcde3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Oct 15, 2024
) (#16325) * Move timestamp pinning before cluster state update * Address PR Comments * Fix IT --------- (cherry picked from commit b5dcde3) Signed-off-by: Gaurav Bafna <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
…nsearch-project#16269) * Move timestamp pinning before cluster state update Signed-off-by: Gaurav Bafna <[email protected]> * Address PR Comments Signed-off-by: Gaurav Bafna <[email protected]> * Fix IT Signed-off-by: Gaurav Bafna <[email protected]> --------- Signed-off-by: Gaurav Bafna <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
…nsearch-project#16269) * Move timestamp pinning before cluster state update Signed-off-by: Gaurav Bafna <[email protected]> * Address PR Comments Signed-off-by: Gaurav Bafna <[email protected]> * Fix IT Signed-off-by: Gaurav Bafna <[email protected]> --------- Signed-off-by: Gaurav Bafna <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
…nsearch-project#16269) * Move timestamp pinning before cluster state update Signed-off-by: Gaurav Bafna <[email protected]> * Address PR Comments Signed-off-by: Gaurav Bafna <[email protected]> * Fix IT Signed-off-by: Gaurav Bafna <[email protected]> --------- Signed-off-by: Gaurav Bafna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Determine pinned timestamp before cluster state update and pin it there itself.
If we determine it too early and cluster state update to put snapshot in progress itself takes more than 1 min , the timestamp pinning fails "Timestamp to be pinned is less than current timestamp - value of cluster.remote_store.pinned_timestamps.lookback_interval" . Due to this snapshot also fails.
This fix will prevent the above failure , when cluster state update takes whatever amount of time.
Check List
API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.