Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] [2.x] Update Apache Lucene to 9.12.0 (#15333) #16211

Merged
merged 1 commit into from
Oct 8, 2024
Merged

[Backport] [2.x] Update Apache Lucene to 9.12.0 (#15333) #16211

merged 1 commit into from
Oct 8, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Oct 7, 2024

Backport of #15333 to 2.x

@reta reta added v2.18.0 Issues and PRs related to version 2.18.0 dependencies Pull requests that update a dependency file labels Oct 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

❌ Gradle check result for 3594150: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta force-pushed the backport/backport-15333-to-2.x branch from 3594150 to 9090acf Compare October 7, 2024 12:54
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

❌ Gradle check result for 9090acf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta force-pushed the backport/backport-15333-to-2.x branch from 9090acf to faab048 Compare October 7, 2024 13:09
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

❌ Gradle check result for faab048: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta @mch2
Update Apache Lucene to 9.12.0 (opensearch-project#15333)
3eb7a76 
* Update Apache Lucene to 9.12.0

Signed-off-by: Andriy Redko <[email protected]>

* change to IOContext READONCE in locations where the file is not expected to be read multiple times.

Signed-off-by: Marc Handalian <[email protected]>

* Use READ IOContext for all non Segment* files when copying node-node

Signed-off-by: Marc Handalian <[email protected]>

* Fixing more test failures

Signed-off-by: Andriy Redko <[email protected]>

* Move Composite912Codec under org.opensearch.index.codec.composite.composite912 package

Signed-off-by: Andriy Redko <[email protected]>

---------

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Marc Handalian <[email protected]>
Co-authored-by: Marc Handalian <[email protected]>
(cherry picked from commit 146b0f7)
Signed-off-by: Andriy Redko <[email protected]>
@reta reta force-pushed the backport/backport-15333-to-2.x branch from faab048 to 3eb7a76 Compare October 7, 2024 13:45
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

❌ Gradle check result for 3eb7a76: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

❌ Gradle check result for 3eb7a76: TIMEOUT

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

❌ Gradle check result for 3eb7a76: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Oct 7, 2024
Open
Closed
Open
Open
Open
Open
@reta
Copy link
Collaborator Author

reta commented Oct 7, 2024

@msfroh please, Apache Lucene 9.12.0 backport, thank you!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

✅ Gradle check result for 3eb7a76: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Oct 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.03704% with 7 lines in your changes missing coverage. Please review.

Project coverage is 71.82%. Comparing base (704e498) to head (3eb7a76).
Report is 9 commits behind head on 2.x.

Files with missing lines Patch % Lines
...in/java/org/apache/lucene/util/CombinedBitSet.java 77.77% 0 Missing and 2 partials ⚠️
.../java/org/opensearch/index/codec/CodecService.java 66.66% 2 Missing ⚠️
...main/java/org/opensearch/common/lucene/Lucene.java 0.00% 1 Missing ⚠️
...opensearch/index/mapper/CompletionFieldMapper.java 0.00% 1 Missing ⚠️
...ensearch/index/similarity/SimilarityProviders.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #16211      +/-   ##
============================================
+ Coverage     71.72%   71.82%   +0.09%     
- Complexity    64773    64888     +115     
============================================
  Files          5284     5285       +1     
  Lines        303053   303068      +15     
  Branches      44086    44089       +3     
============================================
+ Hits         217372   217676     +304     
+ Misses        67457    67215     -242     
+ Partials      18224    18177      -47

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit 2585a23 into opensearch-project:2.x Oct 8, 2024
34 of 35 checks passed
This was referenced Oct 9, 2024
Merged
Merged
@reta reta mentioned this pull request Oct 9, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jed326 jed326 jed326 approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file v2.18.0 Issues and PRs related to version 2.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reta @jed326