Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename field_masking_span to span_field_masking #1606

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Rename field_masking_span to span_field_masking #1606

merged 3 commits into from
Nov 29, 2021

Conversation

xuezhou25
Copy link
Contributor

Description

Rename field_masking_span to span_field_masking as well as maintain backwards compatibility.

Issues Resolved

#1531

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 26d569df5dc7d736538dbc0333b0a6a3b3796217

@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 26d569df5dc7d736538dbc0333b0a6a3b3796217

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 26d569df5dc7d736538dbc0333b0a6a3b3796217
Log 1192

Reports 1192

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success f198eabd30a542605b7f16666da0f65746dae11a

@xuezhou25 xuezhou25 force-pushed the rename_span_field_masking branch from f198eab to 22906a2 Compare November 24, 2021 00:59
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success f198eabd30a542605b7f16666da0f65746dae11a

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 22906a2be1dd378ab3ab9b9131e66b7db8671929

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 22906a2be1dd378ab3ab9b9131e66b7db8671929

@xuezhou25 xuezhou25 force-pushed the rename_span_field_masking branch from 22906a2 to b6ae5cb Compare November 24, 2021 01:13
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success b6ae5cb86f26b0f3efbe02cc4a98e61ec8ac83cc

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success b6ae5cb86f26b0f3efbe02cc4a98e61ec8ac83cc

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success f198eabd30a542605b7f16666da0f65746dae11a
Log 1197

Reports 1197

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 22906a2be1dd378ab3ab9b9131e66b7db8671929
Log 1200

Reports 1200

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure b6ae5cb86f26b0f3efbe02cc4a98e61ec8ac83cc
Log 1201

Reports 1201

@xuezhou25 xuezhou25 force-pushed the rename_span_field_masking branch from b6ae5cb to dd0dc23 Compare November 24, 2021 05:42
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success dd0dc23

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success dd0dc23

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure dd0dc23
Log 1203

Reports 1203

@tlfeng
Copy link
Collaborator

tlfeng commented Nov 24, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success dd0dc23
Log 1204

Reports 1204

@xuezhou25 xuezhou25 marked this pull request as ready for review November 29, 2021 18:52
@xuezhou25 xuezhou25 requested a review from a team as a code owner November 29, 2021 18:52
@dblock dblock merged commit 74943c4 into opensearch-project:main Nov 29, 2021
@dblock dblock added backport 1.x pending backport Identifies an issue or PR that still needs to be backported labels Nov 29, 2021
@VachaShah
Copy link
Collaborator

@xuezhou25 We have an auto-backport mechanism that allows to create backport PRs based on the labels. But since the backport workflow didn't run on this PR with the other checks, this PR would have to backported manually to 1.x.

@xuezhou25
Copy link
Contributor Author

@xuezhou25 We have an auto-backport mechanism that allows to create backport PRs based on the labels. But since the backport workflow didn't run on this PR with the other checks, this PR would have to backported manually to 1.x.

No problem and thanks for reminding me. I don't have access to add labels😂 so next time I will ask the person who has the right access for help before PR merged.

xuezhou25 added a commit to xuezhou25/OpenSearch that referenced this pull request Nov 29, 2021
@xuezhou25
Rename field_masking_span to span_field_masking (opensearch-project#1606
ed7d1c7 
)

* Rename field_masking_span to span_field_masking

Signed-off-by: Xue Zhou <[email protected]>

* Update SearchModuleTests.java

Signed-off-by: Xue Zhou <[email protected]>

* Rename field_masking_span to span_field_masking

Signed-off-by: Xue Zhou <[email protected]>
@xuezhou25 xuezhou25 mentioned this pull request Nov 29, 2021
Merged
5 tasks
dblock pushed a commit that referenced this pull request Nov 30, 2021
@xuezhou25
Rename field_masking_span to span_field_masking (#1606) (#1623)
f9ee754 
* Rename field_masking_span to span_field_masking

Signed-off-by: Xue Zhou <[email protected]>

* Update SearchModuleTests.java

Signed-off-by: Xue Zhou <[email protected]>

* Rename field_masking_span to span_field_masking

Signed-off-by: Xue Zhou <[email protected]>
@dblock dblock removed the pending backport Identifies an issue or PR that still needs to be backported label Dec 6, 2021
@dreamer-89 dreamer-89 mentioned this pull request Mar 14, 2022
Closed
@xuezhou25 xuezhou25 deleted the rename_span_field_masking branch August 2, 2022 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
backport 1.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xuezhou25 @opensearch-ci-bot @tlfeng @VachaShah @dblock