Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport-1.x] Upgrade dependency (#1571) #1594

Merged
merged 1 commit into from
Nov 29, 2021
Merged

[Backport-1.x] Upgrade dependency (#1571) #1594

merged 1 commit into from
Nov 29, 2021

Conversation

VachaShah
Copy link
Collaborator

  • Upgrading guava, commons-io and apache-ant dependencies

Signed-off-by: Vacha [email protected]

  • Adding failureaccess since guava needs it

Signed-off-by: Vacha [email protected]

Description

Backport of #1571

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@VachaShah VachaShah added backport PRs or issues specific to backporting features or enhancments >upgrade Label used when upgrading library dependencies (e.g., Lucene) v1.3.0 labels Nov 19, 2021
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success e40a699f97b4711ae8526d22f2362556cb3052a8

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success e40a699f97b4711ae8526d22f2362556cb3052a8

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure e40a699f97b4711ae8526d22f2362556cb3052a8
Log 1154

Reports 1154

@VachaShah
Copy link
Collaborator Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success e40a699f97b4711ae8526d22f2362556cb3052a8
Log 1180

Reports 1180

@saratvemulapalli
Copy link
Member

saratvemulapalli commented Nov 23, 2021 •
edited
Loading

@VachaShah / @zelinh do we have an update on whitesource?

@zelinh
Copy link
Member

zelinh commented Nov 23, 2021

@VachaShah / @zelinh do we have an update on whitesource?

No, we haven't heard from them regarding of the update of this issue yet. @bbarani Can we ignore the whitesource check at this time?

@VachaShah
Upgrade dependency (opensearch-project#1571)
9c9e7dd 
* Upgrading guava, commons-io and apache-ant dependencies.

Signed-off-by: Vacha <[email protected]>

* Adding failureaccess since guava needs it.

Signed-off-by: Vacha <[email protected]>
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 9c9e7dd

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 9c9e7dd

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 9c9e7dd
Log 1198

Reports 1198

@VachaShah
Copy link
Collaborator Author

start gradle check

@VachaShah
Copy link
Collaborator Author

@zelinh As discussed, I tried to run the WhiteSource scan again but it still fails after 375m each time.

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 9c9e7dd
Log 1208

Reports 1208

@zelinh
Copy link
Member

zelinh commented Nov 24, 2021

I updated the issue regarding our WhiteSource integration. Please refer to #1593.

@VachaShah VachaShah mentioned this pull request Nov 24, 2021
Closed
@VachaShah
Copy link
Collaborator Author

VachaShah commented Nov 29, 2021 •
edited
Loading

The WhiteSource issue is being tracked in #1593 with the team related to a bigger problem on their end. As discussed we could disregard this check till it is fixed, can we merge this PR @saratvemulapalli ?

@saratvemulapalli saratvemulapalli merged commit c0f49b2 into opensearch-project:1.x Nov 29, 2021
@VachaShah VachaShah deleted the 1.x branch November 29, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saratvemulapalli saratvemulapalli saratvemulapalli approved these changes

Assignees
No one assigned
Labels
backport PRs or issues specific to backporting features or enhancments >upgrade Label used when upgrading library dependencies (e.g., Lucene) v1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VachaShah @opensearch-ci-bot @saratvemulapalli @zelinh