Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.17] Add new cluster setting for keyword indexordocvalues query (#15637) #15751

Merged

Conversation

harshavamsi
Copy link
Contributor

@harshavamsi harshavamsi commented Sep 5, 2024

Description

Backport for #15703

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…h-project#15637)

* Add new cluster setting for keyword indexordocvalues query

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Fix tests

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

---------

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
(cherry picked from commit d64baa6)
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
@harshavamsi harshavamsi changed the title Backport/backport 15637 to 2.17 [Backport 2.17] Add new cluster setting for keyword indexordocvalues query (#15637) Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for e93b9fc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for eb41bda: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@harshavamsi
Copy link
Contributor Author

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❕ Gradle check result for eb41bda: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.67%. Comparing base (75fb5bc) to head (0a980fc).
Report is 11 commits behind head on 2.17.

Files with missing lines Patch % Lines
...rg/opensearch/index/mapper/KeywordFieldMapper.java 70.00% 1 Missing and 2 partials ⚠️
.../org/opensearch/search/internal/SearchContext.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               2.17   #15751    +/-   ##
==========================================
  Coverage     71.66%   71.67%            
- Complexity    64317    64475   +158     
==========================================
  Files          5262     5263     +1     
  Lines        301148   301615   +467     
  Branches      43841    43913    +72     
==========================================
+ Hits         215829   216182   +353     
- Misses        67259    67335    +76     
- Partials      18060    18098    +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harshavamsi
Copy link
Contributor Author

#15771 -- should go in after this

Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for 0a980fc: SUCCESS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants