Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SnapshotV2] Version change to V_2.17.0 for node min version check in create snapshot V2 #15644

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

anshu1106
Copy link
Contributor

@anshu1106 anshu1106 commented Sep 4, 2024

Description

This PR changes min node version check to V_2.17.0 in create snapshot v2.

Related Issues

Resolves #15123

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 872aee6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 4, 2024

✅ Gradle check result for 230a358: SUCCESS

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.78%. Comparing base (e087272) to head (7529554).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
...ava/org/opensearch/snapshots/SnapshotsService.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15644      +/-   ##
============================================
- Coverage     72.00%   71.78%   -0.22%     
+ Complexity    64149    64002     -147     
============================================
  Files          5269     5269              
  Lines        299834   299867      +33     
  Branches      43330    43340      +10     
============================================
- Hits         215895   215269     -626     
- Misses        66217    66870     +653     
- Partials      17722    17728       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 253abcc: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 7529554: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 7529554: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for 7529554: SUCCESS

@sachinpkale sachinpkale merged commit 73e14ab into opensearch-project:main Sep 5, 2024
33 of 34 checks passed
@anshu1106 anshu1106 added the backport 2.x Backport to 2.x branch label Sep 5, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2024
Signed-off-by: Anshu Agarwal <[email protected]>
Co-authored-by: Anshu Agarwal <[email protected]>
(cherry picked from commit 73e14ab)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2024
Signed-off-by: Anshu Agarwal <[email protected]>
Co-authored-by: Anshu Agarwal <[email protected]>
(cherry picked from commit 73e14ab)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale pushed a commit that referenced this pull request Sep 5, 2024
(cherry picked from commit 73e14ab)

Signed-off-by: Anshu Agarwal <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Anshu Agarwal <[email protected]>
sachinpkale pushed a commit to sachinpkale/OpenSearch that referenced this pull request Sep 6, 2024
…ject#15644)

Signed-off-by: Anshu Agarwal <[email protected]>
Co-authored-by: Anshu Agarwal <[email protected]>
Signed-off-by: Sachin Kale <[email protected]>
sachinpkale added a commit that referenced this pull request Sep 6, 2024
* Mute test testRemoteStoreCleanupForDeletedIndexForSnapshotV2 (#15695)

Signed-off-by: Marc Handalian <[email protected]>

* Mute flaky test RemoteFsTimestampAwareTranslogTests.testSimpleOperationsUpload (#15732)

Signed-off-by: Sachin Kale <[email protected]>
Co-authored-by: Sachin Kale <[email protected]>

* Mute failing snapshot status tests (#15652)

Signed-off-by: Lakshya Taragi <[email protected]>
Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: Lakshya Taragi <[email protected]>

* Restore snapshot changes for shallow snapshot V2 (#15462)

---------

Signed-off-by: Sachin Kale <[email protected]>
Co-authored-by: Sachin Kale <[email protected]>
Co-authored-by: Gaurav Bafna <[email protected]>
Signed-off-by: Sachin Kale <[email protected]>

* version change to V_2.17.0 for node min version check (#15644)

Signed-off-by: Anshu Agarwal <[email protected]>
Co-authored-by: Anshu Agarwal <[email protected]>
Signed-off-by: Sachin Kale <[email protected]>

---------

Signed-off-by: Marc Handalian <[email protected]>
Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: Lakshya Taragi <[email protected]>
Signed-off-by: Lakshya Taragi <[email protected]>
Signed-off-by: Anshu Agarwal <[email protected]>
Co-authored-by: Marc Handalian <[email protected]>
Co-authored-by: Sachin Kale <[email protected]>
Co-authored-by: Lakshya Taragi <[email protected]>
Co-authored-by: Gaurav Bafna <[email protected]>
Co-authored-by: Anshu Agarwal <[email protected]>
Co-authored-by: Anshu Agarwal <[email protected]>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport 2.17 enhancement Enhancement or improvement to existing feature or request skip-changelog Storage:Snapshots
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Snapshot-V2] Centralize snapshot creation and integrate with timestamp pinning
2 participants