Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x][Remote Publication] Add remote download stats (#15291) #15570

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

Arpit-Bandejiya
Copy link
Contributor

Backport #15291 into 2.x branch.


Signed-off-by: Arpit Bandejiya [email protected]

(cherry picked from commit b54e867)

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Sep 2, 2024

✅ Gradle check result for 38d0a82: SUCCESS

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 69.76744% with 39 lines in your changes missing coverage. Please review.

Project coverage is 71.76%. Comparing base (8a9c167) to head (6a9198a).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ster/coordination/PublicationTransportHandler.java 55.10% 19 Missing and 3 partials ⚠️
...nsearch/gateway/remote/RemotePersistenceStats.java 77.41% 7 Missing ⚠️
...arch/gateway/remote/RemoteClusterStateService.java 77.77% 6 Missing ⚠️
...g/opensearch/cluster/coordination/Coordinator.java 0.00% 2 Missing and 1 partial ⚠️
.../java/org/opensearch/gateway/GatewayMetaState.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15570      +/-   ##
============================================
+ Coverage     71.64%   71.76%   +0.12%     
- Complexity    63909    63993      +84     
============================================
  Files          5240     5241       +1     
  Lines        299047   299111      +64     
  Branches      43535    43539       +4     
============================================
+ Hits         214244   214653     +409     
+ Misses        66881    66483     -398     
- Partials      17922    17975      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix ChangeLog

Copy link
Contributor

github-actions bot commented Sep 2, 2024

❌ Gradle check result for 2630508: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

)

---------
Signed-off-by: Arpit Bandejiya <[email protected]>

(cherry picked from commit b54e867)
Copy link
Contributor

github-actions bot commented Sep 2, 2024

❌ Gradle check result for da098ed: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 2, 2024

❕ Gradle check result for 6a9198a: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@sachinpkale sachinpkale merged commit 834b7c1 into opensearch-project:2.x Sep 2, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants