Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 2.x for (#15428) #15512

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

kaushalmahi12
Copy link
Contributor

Backport 2.x for #15428

* add rejection listener

Signed-off-by: Kaushal Kumar <[email protected]>

* add rejection listener unit test

Signed-off-by: Kaushal Kumar <[email protected]>

* add rejection logic for shard level requests

Signed-off-by: Kaushal Kumar <[email protected]>

* add changelog entry

Signed-off-by: Kaushal Kumar <[email protected]>

* apply spotless check

Signed-off-by: Kaushal Kumar <[email protected]>

* remove unused files and fix precommit

Signed-off-by: Kaushal Kumar <[email protected]>

* refactor code

Signed-off-by: Kaushal Kumar <[email protected]>

* add package info file

Signed-off-by: Kaushal Kumar <[email protected]>

* remove unused method from QueryGroupService stub

Signed-off-by: Kaushal Kumar <[email protected]>

---------

Signed-off-by: Kaushal Kumar <[email protected]>
Copy link
Contributor

❌ Gradle check result for 78688fd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 78688fd: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationAllocationIT.testAllocationAndRebalanceWithDisruption

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.61%. Comparing base (3c9e08b) to head (78688fd).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ain/java/org/opensearch/wlm/QueryGroupService.java 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15512      +/-   ##
============================================
+ Coverage     71.60%   71.61%   +0.01%     
- Complexity    63549    63552       +3     
============================================
  Files          5222     5224       +2     
  Lines        297639   297658      +19     
  Branches      43325    43326       +1     
============================================
+ Hits         213112   213164      +52     
+ Misses        66754    66609     -145     
- Partials      17773    17885     +112     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jainankitk jainankitk merged commit d1cd7a2 into opensearch-project:2.x Aug 30, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants