Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ResourceType API annotations and deprecations #15496

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Aug 29, 2024

Description

Fix ResourceType API annottations and deprecations

Related Issues

Follow up on #15486

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta force-pushed the fix.annoations branch 2 times, most recently from 994566e to 2f7a9f1 Compare August 29, 2024 12:32
@reta reta changed the title Fix ResourceType API annottations and deprecations Fix ResourceType API annotations and deprecations Aug 29, 2024
Copy link
Contributor

❕ Gradle check result for 6691ebd: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

❌ Gradle check result for 994566e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 2f7a9f1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for c4396cc: SUCCESS

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.62%. Comparing base (c2574a5) to head (c4396cc).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
.../main/java/org/opensearch/search/ResourceType.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15496      +/-   ##
============================================
- Coverage     71.69%   71.62%   -0.07%     
+ Complexity    63599    63492     -107     
============================================
  Files          5221     5221              
  Lines        297593   297593              
  Branches      43314    43314              
============================================
- Hits         213351   213145     -206     
- Misses        66442    66579     +137     
- Partials      17800    17869      +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants