Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback on Term-Version check mismatch - Remote cluster-state #15424

Merged

Conversation

rajiv-kv
Copy link
Contributor

@rajiv-kv rajiv-kv commented Aug 26, 2024

Description

On Term-version mismatch,

  1. Fallback to the locally cached cluster-state that is committed in cluster but might not be applied locally.
  2. If remote is enabled, download the cluster-state from remote based on term and version.

Related Issues

Resolves #15414

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

✅ Gradle check result for d87c895: SUCCESS

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 74.76636% with 27 lines in your changes missing coverage. Please review.

Project coverage is 71.85%. Comparing base (92d7fe8) to head (1caa506).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...stermanager/TransportClusterManagerNodeAction.java 67.64% 7 Missing and 4 partials ⚠️
...termanager/term/TransportGetTermVersionAction.java 66.66% 2 Missing and 2 partials ⚠️
...rt/clustermanager/term/GetTermVersionResponse.java 72.72% 1 Missing and 2 partials ⚠️
...arch/gateway/remote/RemoteClusterStateService.java 72.72% 1 Missing and 2 partials ⚠️
...ensearch/gateway/remote/RemoteManifestManager.java 62.50% 2 Missing and 1 partial ⚠️
...g/opensearch/cluster/coordination/Coordinator.java 50.00% 1 Missing and 1 partial ⚠️
...search/gateway/remote/RemoteClusterStateCache.java 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15424      +/-   ##
============================================
- Coverage     71.90%   71.85%   -0.06%     
- Complexity    64216    64251      +35     
============================================
  Files          5272     5278       +6     
  Lines        300597   300794     +197     
  Branches      43440    43464      +24     
============================================
- Hits         216151   216129      -22     
- Misses        66680    66902     +222     
+ Partials      17766    17763       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❌ Gradle check result for f54847d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 7f521d4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 71a447e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions github-actions bot added Cluster Manager enhancement Enhancement or improvement to existing feature or request labels Aug 30, 2024
Copy link
Contributor

❌ Gradle check result for 6fdcd68: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 283e6ab: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rajiv-kv
Copy link
Contributor Author

❌ Gradle check result for 283e6ab: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky Test 14302

Copy link
Contributor

✅ Gradle check result for 0b9dcc3: SUCCESS

Copy link
Contributor

✅ Gradle check result for dd565b1: SUCCESS

Copy link
Contributor

❌ Gradle check result for 4e94c5f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Rajiv Kumar Vaidyanathan <[email protected]>
Copy link
Contributor

❕ Gradle check result for 1caa506: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@shwetathareja shwetathareja merged commit 12ff5ed into opensearch-project:main Sep 12, 2024
33 of 34 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15424-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 12ff5ed9c79aa66c8824e1df7e124756746c8c94
# Push it to GitHub
git push --set-upstream origin backport/backport-15424-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15424-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.17
# Create a new branch
git switch --create backport/backport-15424-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 12ff5ed9c79aa66c8824e1df7e124756746c8c94
# Push it to GitHub
git push --set-upstream origin backport/backport-15424-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-15424-to-2.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed Cluster Manager enhancement Enhancement or improvement to existing feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[ClusterManager - Read Actions] Leverage the ClusterState from Publish phase for serving Admin Read API's
2 participants