Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a whitesource unified agent file and update the config #1540

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Nov 12, 2021

Signed-off-by: Zelin Hao [email protected]

Description

The WhiteSource config was set to default and doesn't seem to work properly for OpenSearch repo. We change the mode to LOCAL and provide the unified agent config file we used before.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@zelinh zelinh requested a review from a team as a code owner November 12, 2021 00:27
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success a22680c

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success a22680c

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure a22680c
Log 1056

Reports 1056

@VachaShah
Copy link
Collaborator

start gradle check

@VachaShah
Copy link
Collaborator

❌   Gradle Check failure a22680c Log 1056

Reports 1056

* What went wrong:
Execution failed for task ':qa:translog-policy:v1.3.0#Step2OldClusterTest'.
> `node{:qa:translog-policy:v1.3.0-0}` failed to wait for ports files after 120000 MILLISECONDS

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure a22680c
Log 1063

Reports 1063

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not include all this commented out settings in whitesource.config and only include things that are required/set. But NBD.

@VachaShah
Copy link
Collaborator

❌   Gradle Check failure a22680c Log 1063

Reports 1063

org.opensearch.cluster.MinimumMasterNodesIT > testTwoNodesNoMasterBlock FAILED
    java.lang.AssertionError: timed out waiting for green state
        at __randomizedtesting.SeedInfo.seed([3971F3035D6294C4:F524D805F8CA81A9]:0)
        at org.junit.Assert.fail(Assert.java:88)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureColor(OpenSearchIntegTestCase.java:1019)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureGreen(OpenSearchIntegTestCase.java:958)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureGreen(OpenSearchIntegTestCase.java:947)
        at org.opensearch.cluster.MinimumMasterNodesIT.testTwoNodesNoMasterBlock(MinimumMasterNodesIT.java:223)

@VachaShah
Copy link
Collaborator

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure a22680c
Log 1088

Reports 1088

@zelinh
Copy link
Member Author

zelinh commented Nov 15, 2021

❌   Gradle Check failure a22680c Log 1088

Reports 1088

Could you help me handle this check? @VachaShah

* What went wrong:
Execution failed for task ':server:internalClusterTest'.
> There were failing tests. See the report at: file:///var/CITOOL/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/search/server/build/reports/tests/internalClusterTest/index.html

@zelinh
Copy link
Member Author

zelinh commented Nov 16, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success a22680c
Log 1104

Reports 1104

@CEHENKLE CEHENKLE merged commit 90a8a72 into opensearch-project:main Nov 17, 2021
@zelinh zelinh deleted the whitesource-config branch November 17, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants