Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused StringBuilder #15360

Closed

Conversation

dk2k
Copy link
Contributor

@dk2k dk2k commented Aug 22, 2024

Removed unused StringBuilder

Signed-off-by: Dmitry Kryukov <[email protected]>
Signed-off-by: Dmitry Kryukov <[email protected]>
Signed-off-by: Dmitry Kryukov <[email protected]>
@dk2k dk2k marked this pull request as draft August 22, 2024 18:18
Copy link
Contributor

❕ Gradle check result for 89bb746: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

❌ Gradle check result for c8afff2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dblock
Copy link
Member

dblock commented Aug 23, 2024

I bet you the intent of this toString was to actually use this StringBulder. Check whether we have a test for this and fix?

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@dbwiddis
Copy link
Member

Closing as this is duplicated by #15362 which has discussion

@dbwiddis dbwiddis closed this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stalled Issues that have stalled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants