Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset discovery nodes in all transport node actions request. #15131

Conversation

SwethaGuptha
Copy link
Contributor

@SwethaGuptha SwethaGuptha commented Aug 6, 2024

Description

Continuation to #14749, we don't required discovery nodes information in most of the transport actions extending TransportNodesActions, hence un-setting the discovery nodes object for such action before sending transport request to individual nodes this will prevent unnecessary serialization/deserialization of the discovery nodes object.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]
#14713

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Aug 6, 2024

❌ Gradle check result for 596132b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@SwethaGuptha SwethaGuptha force-pushed the opensearch-remove-discovery-nodes branch from 596132b to 37f1988 Compare August 7, 2024 03:52
Copy link
Contributor

github-actions bot commented Aug 7, 2024

❌ Gradle check result for 37f1988: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@SwethaGuptha SwethaGuptha force-pushed the opensearch-remove-discovery-nodes branch 2 times, most recently from 7a53b7a to 64ca9ba Compare August 7, 2024 16:45
Copy link
Contributor

github-actions bot commented Aug 7, 2024

✅ Gradle check result for 7a53b7a: SUCCESS

Copy link
Contributor

github-actions bot commented Aug 7, 2024

✅ Gradle check result for 64ca9ba: SUCCESS

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 60.71429% with 11 lines in your changes missing coverage. Please review.

Project coverage is 71.85%. Comparing base (a608fca) to head (e67c726).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ices/dangling/list/ListDanglingIndicesRequest.java 0.00% 2 Missing ⚠️
...luster/node/hotthreads/NodesHotThreadsRequest.java 0.00% 1 Missing ⚠️
...on/admin/cluster/node/usage/NodesUsageRequest.java 0.00% 1 Missing ⚠️
...napshots/status/TransportNodesSnapshotsStatus.java 0.00% 1 Missing ⚠️
...ndices/dangling/find/FindDanglingIndexRequest.java 0.00% 1 Missing ⚠️
...rch/action/support/nodes/TransportNodesAction.java 66.66% 0 Missing and 1 partial ⚠️
...ch/gateway/TransportNodesListGatewayMetaState.java 0.00% 1 Missing ⚠️
...y/TransportNodesListGatewayStartedShardsBatch.java 0.00% 1 Missing ⚠️
...es/store/TransportNodesListShardStoreMetadata.java 0.00% 1 Missing ⚠️
...ore/TransportNodesListShardStoreMetadataBatch.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15131      +/-   ##
============================================
- Coverage     71.96%   71.85%   -0.11%     
+ Complexity    64171    64100      -71     
============================================
  Files          5269     5269              
  Lines        299834   299835       +1     
  Branches      43330    43330              
============================================
- Hits         215769   215454     -315     
- Misses        66344    66629     +285     
- Partials      17721    17752      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SwethaGuptha added a commit to SwethaGuptha/OpenSearch that referenced this pull request Sep 4, 2024
SwethaGuptha added a commit to SwethaGuptha/OpenSearch that referenced this pull request Sep 5, 2024
SwethaGuptha added a commit to SwethaGuptha/OpenSearch that referenced this pull request Sep 5, 2024
shwetathareja pushed a commit that referenced this pull request Sep 5, 2024
SwethaGuptha added a commit to SwethaGuptha/OpenSearch that referenced this pull request Sep 5, 2024
SwethaGuptha added a commit to SwethaGuptha/OpenSearch that referenced this pull request Sep 5, 2024
SwethaGuptha added a commit to SwethaGuptha/OpenSearch that referenced this pull request Sep 5, 2024
SwethaGuptha pushed a commit to SwethaGuptha/OpenSearch that referenced this pull request Sep 5, 2024
SwethaGuptha added a commit to SwethaGuptha/OpenSearch that referenced this pull request Sep 6, 2024
SwethaGuptha added a commit to SwethaGuptha/OpenSearch that referenced this pull request Sep 6, 2024
SwethaGuptha added a commit to SwethaGuptha/OpenSearch that referenced this pull request Sep 6, 2024
SwethaGuptha added a commit to SwethaGuptha/OpenSearch that referenced this pull request Sep 9, 2024
…arch-project#15131)

Signed-off-by: Swetha Guptha <[email protected]>
Co-authored-by: Swetha Guptha <[email protected]>
Signed-off-by: Swetha Guptha <[email protected]>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
shwetathareja pushed a commit that referenced this pull request Sep 12, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants