Make ThreadContext.stashWithOrigin package-private
#14987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
Signed-off-by: Craig Perkins <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14987 +/- ##
============================================
+ Coverage 71.78% 71.94% +0.15%
- Complexity 62694 62821 +127
============================================
Files 5160 5161 +1
Lines 294211 294361 +150
Branches 42553 42577 +24
============================================
+ Hits 211212 211784 +572
+ Misses 65599 65148 -451
- Partials 17400 17429 +29 ☔ View full report in Codecov by Sentry. |
3 tasks
|
I noticed that there is a backport label. Wouldn't this be breaking for |
|
@kotwanikunal I'm planning to close this PR and open a separate one which introduces a permission for this method similar to #15016 IMO I'd ultimately like to change the access modifiers for these methods to make these inaccessible outside of the package and I think its possible to do safely, but there are concerns around changing the access modifier. |
|
Closing in favor of #15039 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ThreadContext class overly exposes many methods as public. Currently,
stashWithOriginis publicly exposed. This PR changes the access modifier on this method to package-private to prevent this internally used method from being exposed publicly.Related Issues
Related to #14931
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.