[Backport 2.x] Apply the date histogram rewrite optimization to range aggregation #14463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…13865) * Refactor the ranges representation Signed-off-by: bowenlan-amzn <[email protected]> * Refactor try fast filter Signed-off-by: bowenlan-amzn <[email protected]> * Main work finished; left the handling of different numeric data types Signed-off-by: bowenlan-amzn <[email protected]> * buildRanges accepts field type Signed-off-by: bowenlan-amzn <[email protected]> * first working draft probably Signed-off-by: bowenlan-amzn <[email protected]> * add change log Signed-off-by: bowenlan-amzn <[email protected]> * accommodate geo distance agg Signed-off-by: bowenlan-amzn <[email protected]> * Fix test support all numeric types minus one on the upper range Signed-off-by: bowenlan-amzn <[email protected]> * [Refactor] range is lower inclusive, right exclusive Signed-off-by: bowenlan-amzn <[email protected]> * adding test Signed-off-by: bowenlan-amzn <[email protected]> * Adding test and refactor Signed-off-by: bowenlan-amzn <[email protected]> * refactor Signed-off-by: bowenlan-amzn <[email protected]> * add test Signed-off-by: bowenlan-amzn <[email protected]> * add test and update the compare logic in tree traversal Signed-off-by: bowenlan-amzn <[email protected]> * fix test, add random test Signed-off-by: bowenlan-amzn <[email protected]> * refactor to address comments Signed-off-by: bowenlan-amzn <[email protected]> * small potential performance update Signed-off-by: bowenlan-amzn <[email protected]> * fix precommit Signed-off-by: bowenlan-amzn <[email protected]> * refactor Signed-off-by: bowenlan-amzn <[email protected]> * refactor Signed-off-by: bowenlan-amzn <[email protected]> * set refresh_interval to -1 Signed-off-by: bowenlan-amzn <[email protected]> * address comment Signed-off-by: bowenlan-amzn <[email protected]> * address comment Signed-off-by: bowenlan-amzn <[email protected]> * address comment Signed-off-by: bowenlan-amzn <[email protected]> * Fix test To understand fully about the double and bigdecimal usage in scaled float field will take more time. Signed-off-by: bowenlan-amzn <[email protected]> --------- Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit 57fb50b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
mch2
approved these changes
Jun 20, 2024
kkewwei
pushed a commit
to kkewwei/OpenSearch
that referenced
this pull request
Jul 24, 2024
…pensearch-project#13865) (opensearch-project#14463) * Refactor the ranges representation * Refactor try fast filter * Main work finished; left the handling of different numeric data types * buildRanges accepts field type * first working draft probably * add change log * accommodate geo distance agg * Fix test support all numeric types minus one on the upper range * [Refactor] range is lower inclusive, right exclusive * adding test * Adding test and refactor * refactor * add test * add test and update the compare logic in tree traversal * fix test, add random test * refactor to address comments * small potential performance update * fix precommit * refactor * refactor * set refresh_interval to -1 * address comment * address comment * address comment * Fix test To understand fully about the double and bigdecimal usage in scaled float field will take more time. --------- (cherry picked from commit 57fb50b) Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 57fb50b from #13865.