Make sure processPostCollection is called in case of early termination #14208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jed326
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
github-actions
bot
added
bug
|
❌ Gradle check result for 1b91933: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Jay Deng <[email protected]>
reta
approved these changes
Jun 12, 2024
74 tasks
sohami
approved these changes
Jun 12, 2024
|
❕ Gradle check result for c56c693: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14208 +/- ##
============================================
+ Coverage 71.42% 71.73% +0.30%
- Complexity 59978 62059 +2081
============================================
Files 4985 5117 +132
Lines 282275 291683 +9408
Branches 40946 42165 +1219
============================================
+ Hits 201603 209225 +7622
- Misses 63999 65212 +1213
- Partials 16673 17246 +573 ☔ View full report in Codecov by Sentry. |
mch2
approved these changes
Jun 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 12, 2024
#14208) Signed-off-by: Jay Deng <[email protected]> (cherry picked from commit 5093901) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jed326
added a commit
to jed326/OpenSearch
that referenced
this pull request
Jun 12, 2024
opensearch-project#14208) Signed-off-by: Jay Deng <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 12, 2024
#14208) Signed-off-by: Jay Deng <[email protected]> (cherry picked from commit 5093901) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
3 tasks
jed326
pushed a commit
that referenced
this pull request
Jun 12, 2024
#14208) (#14214) (cherry picked from commit 5093901) Signed-off-by: Jay Deng <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Jun 12, 2024
#14208) (#14213) (cherry picked from commit 5093901) Signed-off-by: Jay Deng <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
3 tasks
harshavamsi
pushed a commit
to harshavamsi/OpenSearch
that referenced
this pull request
Jul 12, 2024
opensearch-project#14208) Signed-off-by: Jay Deng <[email protected]>
kkewwei
pushed a commit
to kkewwei/OpenSearch
that referenced
this pull request
Jul 24, 2024
opensearch-project#14208) (opensearch-project#14213) (cherry picked from commit 5093901) Signed-off-by: Jay Deng <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <[email protected]>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
opensearch-project#14208) Signed-off-by: Jay Deng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure processPostCollection is still called when early termination kicks in.
Related Issues
Resolves #14198
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.