-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create serde utility for Writable classes #14095
Create serde utility for Writable classes #14095
Conversation
❌ Gradle check result for 73f7270: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 7388ee9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14095 +/- ##
============================================
+ Coverage 71.42% 71.78% +0.36%
- Complexity 59978 61689 +1711
============================================
Files 4985 5090 +105
Lines 282275 289467 +7192
Branches 40946 41862 +916
============================================
+ Hits 201603 207803 +6200
- Misses 63999 64516 +517
- Partials 16673 17148 +475 ☔ View full report in Codecov by Sentry. |
server/src/main/java/org/opensearch/repositories/blobstore/ChecksumWritableBlobStoreFormat.java
Outdated
Show resolved
Hide resolved
6ab7b90
to
fa5caec
Compare
❌ Gradle check result for 63e28d4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sooraj Sinha <[email protected]>
❌ Gradle check result for b9b8075: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for b9b8075: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
flaky #12675 |
|
❌ Gradle check result for b9b8075: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Flaky test: #14129 |
❕ Gradle check result for b9b8075: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
* Create serde utility for Writable classes Signed-off-by: Sooraj Sinha <[email protected]> (cherry picked from commit 7f0ff14) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Create serde utility for Writable classes (cherry picked from commit 7f0ff14) Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Create serde utility for Writable classes Signed-off-by: Sooraj Sinha <[email protected]>
…pensearch-project#14133) * Create serde utility for Writable classes (cherry picked from commit 7f0ff14) Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <[email protected]>
* Create serde utility for Writable classes Signed-off-by: Sooraj Sinha <[email protected]>
Description
Create a class which will serialize and deserialize classes extending Writable interface. This class handles the checksum logic as well.
Related Issues
NA
Check List
API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.