Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create serde utility for Writable classes #14095

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

soosinha
Copy link
Member

@soosinha soosinha commented Jun 8, 2024

Description

Create a class which will serialize and deserialize classes extending Writable interface. This class handles the checksum logic as well.

Related Issues

NA

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jun 8, 2024

❌ Gradle check result for 73f7270: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 8, 2024

❌ Gradle check result for 7388ee9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 9, 2024

✅ Gradle check result for 6ab7b90: SUCCESS

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.78%. Comparing base (b15cb0c) to head (b9b8075).
Report is 381 commits behind head on main.

Files Patch % Lines
...ies/blobstore/ChecksumWritableBlobStoreFormat.java 89.28% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14095      +/-   ##
============================================
+ Coverage     71.42%   71.78%   +0.36%     
- Complexity    59978    61689    +1711     
============================================
  Files          4985     5090     +105     
  Lines        282275   289467    +7192     
  Branches      40946    41862     +916     
============================================
+ Hits         201603   207803    +6200     
- Misses        63999    64516     +517     
- Partials      16673    17148     +475     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❌ Gradle check result for 63e28d4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for b9b8075: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for b9b8075: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@soosinha
Copy link
Member Author

❌ Gradle check result for b9b8075: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

flaky #12675

@shwetathareja
Copy link
Member

❌ Gradle check result for b9b8075: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

#12675

Copy link
Contributor

❌ Gradle check result for b9b8075: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@soosinha
Copy link
Member Author

❌ Gradle check result for b9b8075: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test: #14129

Copy link
Contributor

❕ Gradle check result for b9b8075: UNSTABLE

  • TEST FAILURES:
      3 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@shwetathareja shwetathareja merged commit 7f0ff14 into opensearch-project:main Jun 10, 2024
30 checks passed
@shwetathareja shwetathareja added the backport 2.x Backport to 2.x branch label Jun 10, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 10, 2024
* Create serde utility for Writable classes

Signed-off-by: Sooraj Sinha <[email protected]>
(cherry picked from commit 7f0ff14)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shwetathareja pushed a commit that referenced this pull request Jun 10, 2024
* Create serde utility for Writable classes

(cherry picked from commit 7f0ff14)

Signed-off-by: Sooraj Sinha <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
* Create serde utility for Writable classes

Signed-off-by: Sooraj Sinha <[email protected]>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…pensearch-project#14133)

* Create serde utility for Writable classes

(cherry picked from commit 7f0ff14)

Signed-off-by: Sooraj Sinha <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <[email protected]>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
* Create serde utility for Writable classes

Signed-off-by: Sooraj Sinha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants