-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to iterative version of WKT format parser #14086
Conversation
❌ Gradle check result for 9a429ef: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 24305a5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14086 +/- ##
============================================
+ Coverage 71.42% 71.77% +0.35%
- Complexity 59978 62159 +2181
============================================
Files 4985 5118 +133
Lines 282275 291877 +9602
Branches 40946 42189 +1243
============================================
+ Hits 201603 209500 +7897
- Misses 63999 65123 +1124
- Partials 16673 17254 +581 ☔ View full report in Codecov by Sentry. |
libs/geo/src/main/java/org/opensearch/geometry/utils/WellKnownText.java
Outdated
Show resolved
Hide resolved
libs/geo/src/main/java/org/opensearch/geometry/utils/WellKnownText.java
Outdated
Show resolved
Hide resolved
libs/geo/src/main/java/org/opensearch/geometry/utils/WellKnownText.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for 920c417: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Test Result (1 failure / -8) Flaky test. #12407 |
libs/geo/src/main/java/org/opensearch/geometry/utils/WellKnownText.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for 920c417: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Heemin Kim <[email protected]>
❌ Gradle check result for 47ce156: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
LGTM, can you please resolve conflicts and lets wait for CI to succeed. I guess there are some ongoing flaky tests. |
Signed-off-by: Heemin Kim <[email protected]>
❕ Gradle check result for a8aef7d: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit 120678d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 120678d) Signed-off-by: Heemin Kim <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…14086) Signed-off-by: Heemin Kim <[email protected]>
…14086) (opensearch-project#14431) (cherry picked from commit 120678d) Signed-off-by: Heemin Kim <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <[email protected]>
…14086) Signed-off-by: Heemin Kim <[email protected]>
Description
Switch to iterative version of WKT format parser
Related Issues
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.