Fix allowUnmappedFields, mapUnmappedFieldAsString settings to be applied when parsing query string query

[imyp92]

Description

PR to solve problems where the allowUnmappedFields, mapUnmappedFieldAsString settings do not apply to certain query types when parsing query_string queries containing unmapped fields. I've modified to call the QueryShardContext.fieldMapper() method, which applies the allowUnmappedFields, mapUnmappedFieldAsString setting to the return of MapperService.fieldType() instead of calling and using the return of MapperService.fieldType() directly.

Related Issues

Resolves #12141

Further description of the issue

• In the process of parsing a query_string, the following types of queries do not throw exception of 'QueryShardException(this, "No field mapping can be found for the field with name [{}], name)' even if the allowUnmappedFields and mapUnmappedFieldAsString settings are set to false.

  • wildcard query
    • unmappedField: * or unmappedField: *test
  • _exists_ query
    • _exists_: unmappedField
  • range query
    • unmappedField: <100
  • fuzzy query
    • unmappedField: test~
  • prefix query
    • unmappedField: test*

• The default value of allowUnmappedFields is true, and the default value of mapUnmappedFieldAsString is false, so if those settings are not customized, there will be no issue with search, but when indexing percolator documents, the issue arises regardless of whether the setting is customized or not because the allowUnmappedFields field of context object is set to false in PercolatorFieldMapper.parse() by invoking PercolatorFieldMapper.configureContext().

To Reproduce

1. Create a test index

curl --location --request PUT 'localhost:9200/test' \
--header 'Content-Type: application/json' \
--data '{
  "settings": {      
    "index": {
      "query": {
        "parse": {
          "allow_unmapped_fields": false
        }
      }
    }    
  },
  "mappings": {
    "properties": {
      "query": {                
        "type": "percolator"            
      }
    }
  }
}'

2. Send a percolator document creation request or search request with a query containing a field where mapping does not exist

curl --location --request PUT 'localhost:9200/test/_doc/test-id' \
--header 'Content-Type: application/json' \
--data '{
  "query": {
    "query_string": {
      "query": "unmappedField: test"
    }
  }
}'

or

curl --location 'http://localhost:9200/test/_search' \
--header 'Content-Type: application/json' \
--data '{ 
  "query": { 
    "query_string": { 
      "query": "unmappedField: test" 
    }
  }
}'

• when query type is field query(when getFieldQuery(String field, String queryText, int slop)is called)
  • returns response with message that field mapping does not exist which is expected when allow_unmapped_fields is set to false
    • which is expected

{
  "error": {
    "root_cause": [
      {
        "type": "query_shard_exception",
        "reason": "No field mapping can be found for the field with name [unmappedField]",
        "index": "test",
        "index_uuid": "FSnBe-D3TEC8l1CQlu6uBQ"
      }
    ],
    "type": "search_phase_execution_exception",
    "reason": "all shards failed",
    "phase": "query",
    "grouped": true,
    "failed_shards": [
      {
        "shard": 0,
        "index": "test",
        "node": "U3GpcjP1RleoYleHB1NgSQ",
        "reason": {
          "type": "query_shard_exception",
          "reason": "No field mapping can be found for the field with name [unmappedField]",
          "index": "test",
          "index_uuid": "FSnBe-D3TEC8l1CQlu6uBQ"
        }
      }
    ]
  },
  "status": 400
}

• If the query type is one of the following:
  • wildcard query
    • unmappedField: * or unmappedField: *test
  • _exists_ query
    • _exists_: unmappedField
  • range query
    • unmappedField: <100
  • fuzzy query
    • unmappedField: test~
  • prefix query
    • unmappedField: test*
• 2xx response is returned
  • Internally parsed to MatchNoDocsQuery type, so it does not match any documents

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• API changes companion pull request created.
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for 18d66b0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for ab3e26d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 4241883: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[imyp92]

@imyp92 Thanks! Amend your commits with -s for DCO, iterate to green.

I've amended all commits

[github-actions]

❕ Gradle check result for f5c9a2d: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[dblock]

@gaobinlong please do hit merge when you approve so we don't get a conflict and have to restart gradles

[gaobinlong]

@gaobinlong please do hit merge when you approve so we don't get a conflict and have to restart gradles

Sure, thank you!