Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Fix flaky test S3BlobStoreRepositoryTests.testRequestStats #13898

Merged
merged 1 commit into from
May 30, 2024
Merged

[Backport 2.x] Fix flaky test S3BlobStoreRepositoryTests.testRequestStats #13898

merged 1 commit into from
May 30, 2024

Commits on May 30, 2024

  1. Fix flaky test S3BlobStoreRepositoryTests.testRequestStats (#13887) 

    If a BlobStoreRepository is created, but the blobStore() method is never
called, then the actual blobStore instance won't be created. This means
the repository will always emit non-detailed empty stats. When we would
try to merge these stats with another repository that was initialized,
it would fail the assertion that they either both have detailed stats or
neither did.

This fix looks like it's checking if the blobStore has been
initialized, but by calling blobStore(), it's making sure that it gets
initialized.

Signed-off-by: Michael Froh <[email protected]>
(cherry picked from commit c7e8421)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
    @github-actions
    github-actions[bot] committed May 30, 2024
    Configuration menu
    Copy the full SHA
    30b38c5 View commit details
    Browse the repository at this point in the history