Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flaky Test PersistentTasksExecutorFullRestartIT.testFullClusterRe… #13350

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

Pranshu-S
Copy link
Contributor

@Pranshu-S Pranshu-S commented Apr 23, 2024

Description

Addresses fix for Flaky Test PersistentTasksExecutorFullRestartIT.testFullClusterRestart which is caused in scenarios of Cluster State not being able to remove all the Persistent Tasks as a part of the test in the default 10 seconds time limit.

This change increases the time limit to 20 seconds

Related Issues

Resolves #5145

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added bug Something isn't working Cluster Manager flaky-test Random test failure that succeeds on second run labels Apr 23, 2024
Copy link
Contributor

✅ Gradle check result for 077963f: SUCCESS

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.35%. Comparing base (b15cb0c) to head (077963f).
Report is 210 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13350      +/-   ##
============================================
- Coverage     71.42%   71.35%   -0.07%     
- Complexity    59978    60562     +584     
============================================
  Files          4985     5039      +54     
  Lines        282275   285432    +3157     
  Branches      40946    41337     +391     
============================================
+ Hits         201603   203658    +2055     
- Misses        63999    64896     +897     
- Partials      16673    16878     +205     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock
Copy link
Member

dblock commented Apr 23, 2024

LGTM, finish the PR description/checklist? Mark this as ready and we can merge.

@dblock dblock added skip-changelog backport 2.x Backport to 2.x branch labels Apr 23, 2024
@deshsidd
Copy link
Contributor

LGTM @Pranshu-S Can you perform the required actions as mentioned above to merge

@dblock dblock merged commit c055a3d into opensearch-project:main Apr 25, 2024
80 of 83 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 25, 2024
…start (#13350)

Signed-off-by: Pranshu Shukla <[email protected]>
(cherry picked from commit c055a3d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock pushed a commit that referenced this pull request Apr 25, 2024
…start (#13350) (#13371)

(cherry picked from commit c055a3d)

Signed-off-by: Pranshu Shukla <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working Cluster Manager flaky-test Random test failure that succeeds on second run skip-changelog
Projects
Status: ✅ Done
3 participants