Reconsider the breaking changes check policy to detect breaking changes against released versions #13292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
github-actions
bot
added
Build
…es against released versions Signed-off-by: Andriy Redko <[email protected]>
reta
force-pushed
the
breaking.again.release
branch
from
0d84dc4
to
54ac60d
Compare
peternied
reviewed
Apr 18, 2024
|
❌ Gradle check result for 0d84dc4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13292 +/- ##
============================================
+ Coverage 71.42% 71.50% +0.08%
- Complexity 59978 60668 +690
============================================
Files 4985 5039 +54
Lines 282275 285434 +3159
Branches 40946 41338 +392
============================================
+ Hits 201603 204108 +2505
- Misses 63999 64426 +427
- Partials 16673 16900 +227 ☔ View full report in Codecov by Sentry. |
…cmp tasks Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
reta
force-pushed
the
breaking.again.release
branch
from
7cbb3a0
to
fb7eafd
Compare
|
❌ Gradle check result for 7cbb3a0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
peternied
approved these changes
Apr 19, 2024
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13292-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b4692c897ec4b19161417147d29b116671616fe1
# Push it to GitHub
git push --set-upstream origin backport/backport-13292-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
reta
added a commit
to reta/OpenSearch
that referenced
this pull request
Apr 19, 2024
…es against released versions (opensearch-project#13292) * Reconsider the breaking changes check policy to detect breaking changes against released versions Signed-off-by: Andriy Redko <[email protected]> * Add an ability to provide the target version to compare with for japicmp tasks Signed-off-by: Andriy Redko <[email protected]> * Add documentation for japicmp tasks Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit b4692c8)
reta
added a commit
to reta/OpenSearch
that referenced
this pull request
Apr 19, 2024
…es against released versions (opensearch-project#13292) * Reconsider the breaking changes check policy to detect breaking changes against released versions Signed-off-by: Andriy Redko <[email protected]> * Add an ability to provide the target version to compare with for japicmp tasks Signed-off-by: Andriy Redko <[email protected]> * Add documentation for japicmp tasks Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit b4692c8) Signed-off-by: Andriy Redko <[email protected]>
peternied
pushed a commit
that referenced
this pull request
Apr 19, 2024
…es against released versions (#13292) (#13310) (cherry picked from commit b4692c8) Signed-off-by: Andriy Redko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reconsider the breaking changes check policy to detect breaking changes against released versions. The check still remains disabled for
mainfor now.Related Issues
Resolves #13275
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.