Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search Pipeline]Handled default search pipeline for multiple indices #13276

Merged
merged 3 commits into from
Apr 29, 2024
Merged

[Search Pipeline]Handled default search pipeline for multiple indices #13276

merged 3 commits into from
Apr 29, 2024

Conversation

owaiskazi19
Copy link
Member

@owaiskazi19 owaiskazi19 commented Apr 18, 2024 •
edited
Loading

Description

In #7470, we added the ability to specify a search pipeline that will execute by default for queries against a single index.
This PR handles a check to see if all the concrete indices have the same default pipeline and attached it.

Related Issues

Resolves #7512

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc Search:Relevance labels Apr 18, 2024
@owaiskazi19 owaiskazi19 force-pushed the multiple-index-search-pipeline branch 3 times, most recently from ea735f4 to 908c67e Compare April 18, 2024 01:28
@owaiskazi19 owaiskazi19 added the backport 2.x Backport to 2.x branch label Apr 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for ed37dc9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for ea735f4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b5dbfc8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

dbwiddis
dbwiddis approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for a4b65df: SUCCESS

@owaiskazi19 owaiskazi19 requested a review from msfroh April 25, 2024 05:49
@owaiskazi19 owaiskazi19 force-pushed the multiple-index-search-pipeline branch from a4b65df to ad25851 Compare April 26, 2024 21:34
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for ad25851: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@owaiskazi19 owaiskazi19 mentioned this pull request Apr 26, 2024
Closed
4 tasks
@owaiskazi19 owaiskazi19 force-pushed the multiple-index-search-pipeline branch from ad25851 to e393181 Compare April 29, 2024 01:50
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for ad25851: SUCCESS

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for e393181: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@owaiskazi19
Copy link
Member Author

❌ Gradle check result for e393181: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

#12197

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for e393181: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for e393181: SUCCESS

@owaiskazi19 owaiskazi19 force-pushed the multiple-index-search-pipeline branch from e393181 to 6f36ec5 Compare April 29, 2024 15:44
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 6f36ec5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dbwiddis
Copy link
Member

Failed gradle check tracked in #13437

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 6f36ec5: SUCCESS

@andrross andrross merged commit defbd60 into opensearch-project:main Apr 29, 2024
28 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 29, 2024
@github-actions
Handle default search pipeline for multiple indices (#13276)
67c6087 
Signed-off-by: Owais Kazi <[email protected]>
(cherry picked from commit defbd60)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 29, 2024
Merged
@owaiskazi19 owaiskazi19 mentioned this pull request Apr 29, 2024
Merged
1 task
owaiskazi19 pushed a commit that referenced this pull request Apr 30, 2024
@opensearch-trigger-bot @github-actions
Handle default search pipeline for multiple indices (#13276) (#13454)
5fe3568 
(cherry picked from commit defbd60)

Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@BrewTestBot BrewTestBot mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbwiddis dbwiddis dbwiddis approved these changes

@andrross andrross andrross approved these changes

@msfroh msfroh msfroh approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request Search:Relevance Search Search query, autocomplete ...etc v2.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Search Pipelines] How should we handle default pipelines for multiple indices? Aliases? Wildcards?
4 participants
@owaiskazi19 @dbwiddis @msfroh @andrross