Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish contributing updates; thanks @acarbonetto #12981

Merged
merged 17 commits into from
Apr 5, 2024
Merged

Finish contributing updates; thanks @acarbonetto #12981

merged 17 commits into from
Apr 5, 2024

Conversation

stephen-crawford
Copy link
Contributor

@stephen-crawford stephen-crawford commented Mar 29, 2024 •
edited
Loading

Description

I was going over old PRs and found this one which just needed a little help over the finish line

If someone could add skip-changelog that would be appreciated.

Related Issues

#7107

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@stephen-crawford
Fix indenting
79f03af 
Signed-off-by: Stephen Crawford <[email protected]>
@stephen-crawford
Readd build failure notes
cc96f6b 
Signed-off-by: Stephen Crawford <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 29, 2024 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change aa45cda

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

dblock
dblock requested changes Mar 29, 2024
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There'a a lot of duplication with the content in developer guide, we should just add enough that links to it.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 576a56e: SUCCESS

stephen-crawford and others added 8 commits April 4, 2024 09:41
@stephen-crawford @owaiskazi19
Update CONTRIBUTING.md
4750e99 
Co-authored-by: Owais Kazi <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
@stephen-crawford @owaiskazi19
Update CONTRIBUTING.md
c10c569 
Co-authored-by: Owais Kazi <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
@stephen-crawford @owaiskazi19
Update CONTRIBUTING.md
3bef242 
Co-authored-by: Owais Kazi <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
@stephen-crawford @owaiskazi19
Update CONTRIBUTING.md
b82607a 
Co-authored-by: Owais Kazi <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
@stephen-crawford @owaiskazi19
Update CONTRIBUTING.md
610d544 
Co-authored-by: Owais Kazi <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
@stephen-crawford @owaiskazi19
Update CONTRIBUTING.md
3160181 
Co-authored-by: Owais Kazi <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
@stephen-crawford @owaiskazi19
Update CONTRIBUTING.md
2820836 
Co-authored-by: Owais Kazi <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
@stephen-crawford @owaiskazi19
Update CONTRIBUTING.md
ef2ed75 
Co-authored-by: Owais Kazi <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

❌ Gradle check result for 3bef242: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

❌ Gradle check result for 4750e99: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

❌ Gradle check result for b82607a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

❌ Gradle check result for c10c569: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

❌ Gradle check result for ef2ed75: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

❌ Gradle check result for 2820836: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@stephen-crawford
Copy link
Contributor Author

This is just a documentation change so I don't think the failure is related at all. @owaiskazi19 would you be able to approve? Thank you

@owaiskazi19
Copy link
Member

This is just a documentation change so I don't think the failure is related at all. @owaiskazi19 would you be able to approve? Thank you

Let's wait for the gradle check to pass. I just triggered it again.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

❌ Gradle check result for ef2ed75: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@owaiskazi19
Copy link
Member

@scrawfor99 did you rebase your changes with latest main?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

❌ Gradle check result for ef2ed75: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

✅ Gradle check result for aa45cda: SUCCESS

@owaiskazi19 owaiskazi19 merged commit 19d6c5c into opensearch-project:main Apr 5, 2024
31 checks passed
@owaiskazi19 owaiskazi19 added the backport 2.x Backport to 2.x branch label Apr 5, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 5, 2024
@github-actions @acarbonetto @owaiskazi19
Finish contributing updates; thanks @acarbonetto (#12981)
828ec4e 
* Finish contributing updates; thanks @acarbonetto

Signed-off-by: Stephen Crawford <[email protected]>

* Fix indenting

Signed-off-by: Stephen Crawford <[email protected]>

* Readd build failure notes

Signed-off-by: Stephen Crawford <[email protected]>

* Update CONTRIBUTING with review tips

Signed-off-by: Andrew Carbonetto <[email protected]>

* Update CONTRIBUTING with review tips

Signed-off-by: Andrew Carbonetto <[email protected]>

* Update contributing comment for review comment

Signed-off-by: Andrew Carbonetto <[email protected]>

* Fix contruibuting doc

Signed-off-by: Stephen Crawford <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Owais Kazi <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Owais Kazi <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Owais Kazi <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Owais Kazi <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Owais Kazi <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Owais Kazi <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Owais Kazi <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Owais Kazi <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>

---------

Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
Co-authored-by: Andrew Carbonetto <[email protected]>
Co-authored-by: Owais Kazi <[email protected]>
(cherry picked from commit 19d6c5c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 5, 2024
Merged
kotwanikunal pushed a commit that referenced this pull request Apr 9, 2024
@opensearch-trigger-bot @github-actions
@acarbonetto @owaiskazi19
Finish contributing updates; thanks @acarbonetto (#12981) (#13088)
36dc170 
* Finish contributing updates; thanks @acarbonetto



* Fix indenting



* Readd build failure notes



* Update CONTRIBUTING with review tips



* Update CONTRIBUTING with review tips



* Update contributing comment for review comment



* Fix contruibuting doc



* Update CONTRIBUTING.md




* Update CONTRIBUTING.md




* Update CONTRIBUTING.md




* Update CONTRIBUTING.md




* Update CONTRIBUTING.md




* Update CONTRIBUTING.md




* Update CONTRIBUTING.md




* Update CONTRIBUTING.md




---------






(cherry picked from commit 19d6c5c)

Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andrew Carbonetto <[email protected]>
Co-authored-by: Owais Kazi <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@stephen-crawford @acarbonetto
@owaiskazi19 @shiv0408
Finish contributing updates; thanks @acarbonetto (opensearch-project#…
d33320d 
…12981)

* Finish contributing updates; thanks @acarbonetto

Signed-off-by: Stephen Crawford <[email protected]>

* Fix indenting

Signed-off-by: Stephen Crawford <[email protected]>

* Readd build failure notes

Signed-off-by: Stephen Crawford <[email protected]>

* Update CONTRIBUTING with review tips

Signed-off-by: Andrew Carbonetto <[email protected]>

* Update CONTRIBUTING with review tips

Signed-off-by: Andrew Carbonetto <[email protected]>

* Update contributing comment for review comment

Signed-off-by: Andrew Carbonetto <[email protected]>

* Fix contruibuting doc

Signed-off-by: Stephen Crawford <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Owais Kazi <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Owais Kazi <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Owais Kazi <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Owais Kazi <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Owais Kazi <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Owais Kazi <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Owais Kazi <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Owais Kazi <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>

---------

Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
Co-authored-by: Andrew Carbonetto <[email protected]>
Co-authored-by: Owais Kazi <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
@peternied
Copy link
Member

@scrawfor99 I think there was a bad merge conflict - it looks like this PR deleted the contribution [1] by @reta. Could you please restore the Troubleshooting Failing Builds section?

@stephen-crawford stephen-crawford mentioned this pull request Apr 26, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

@owaiskazi19 owaiskazi19 owaiskazi19 approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stephen-crawford @owaiskazi19 @peternied @dblock @acarbonetto