Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tiered Caching] Stats rework (1/3): Interfaces and implementations for individual tiers #12531

Merged
merged 82 commits into from
Apr 12, 2024
Merged

[Tiered Caching] Stats rework (1/3): Interfaces and implementations for individual tiers #12531

merged 82 commits into from
Apr 12, 2024

Commits on Mar 4, 2024

  1. Changes ICache to use ICacheKey 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    f6e2330 View commit details
    Browse the repository at this point in the history

  2. Added CacheStats interface 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    9e147c8 View commit details
    Browse the repository at this point in the history

  3. added cacheStats impl 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    a1f249a View commit details
    Browse the repository at this point in the history

  4. Added serializers 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    3783684 View commit details
    Browse the repository at this point in the history

  5. Changes to ICache builders etc 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    3623858 View commit details
    Browse the repository at this point in the history

  6. added cache dimension tests 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    818c43d View commit details
    Browse the repository at this point in the history

  7. Changed on heap cache to align with new interfaces 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    64fb5ea View commit details
    Browse the repository at this point in the history

  8. Made TSC use the new interface changes 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    9dd7e1b View commit details
    Browse the repository at this point in the history

  9. Made stats() part of ICache interface 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    09be0ad View commit details
    Browse the repository at this point in the history

  10. Changed ehcache to work with new changes to interfaces 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    52098b0 View commit details
    Browse the repository at this point in the history

  11. spotlessApply 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    04d0b62 View commit details
    Browse the repository at this point in the history

  12. Suppresses rawtypes warnings where needed in ehcache 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    ad2b4ce View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. More spotlessApply 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    9a29a46 View commit details
    Browse the repository at this point in the history

  2. Changes TSC tests to work with new changes 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    17e93fb View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into tiramisu-stats-tiers

    Peter Alfonsi committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    1c122e3 View commit details
    Browse the repository at this point in the history

  4. More spotlessApply 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    5cf3585 View commit details
    Browse the repository at this point in the history

  5. Suppressed unchecked cast warnings where needed 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    9d27f38 View commit details
    Browse the repository at this point in the history

  6. more unchecked 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    f1affc1 View commit details
    Browse the repository at this point in the history

  7. Fixed missing dimension names in TSC on heap cache builder 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    f841d7a View commit details
    Browse the repository at this point in the history

  8. Fixed failing UT 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    5f62582 View commit details
    Browse the repository at this point in the history

  9. commented out test which leaks threads 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    0345e27 View commit details
    Browse the repository at this point in the history

  10. Javadocs 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    25852a1 View commit details
    Browse the repository at this point in the history

  11. Rerunning gradle for flaky test failure 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    70f6222 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. rerun gradle again 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    6a4a195 View commit details
    Browse the repository at this point in the history

  2. Fixed flaky ehcache test 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    cd0d430 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into tiramisu-stats-tiers

    Peter Alfonsi committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    0d82d9b View commit details
    Browse the repository at this point in the history

  4. Addressed Sagar's comments 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    17c2202 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Removed commented-out stats lines in TSC 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    ca13c5f View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Addressed Sagar's minor comments 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    a40211f View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2024

  1. Addressed Sagar's comment on allowing user to pick which dimension co… 

    …mbinations to track

Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    a2d1986 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Addressed Michael's comments 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    5411ad7 View commit details
    Browse the repository at this point in the history

  2. Addressed Michael's round 2 comments 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    a0ff075 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into tiramisu-stats-tiers

    Peter Alfonsi committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    81f4806 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Integrate stats changes with most recent IRC changes 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    25570e4 View commit details
    Browse the repository at this point in the history

  2. Fixed failing test 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    ad01eec View commit details
    Browse the repository at this point in the history

  3. Addressed Sagar's comments 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    4828327 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Merge remote-tracking branch 'upstream/main' into tiramisu-stats-tiers

    Peter Alfonsi committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    a54e545 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Addressed minor comments + stats reset on index deletion 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    4d2da13 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into tiramisu-stats-tiers

    Peter Alfonsi committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    4f955fd View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Misc cleanup/reorganization 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    5ecdcff View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Changed aggregateByLevels to return tree structure 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    fb3baaa View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. changed statsholder key to contain whole dimension 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    b5bded2 View commit details
    Browse the repository at this point in the history

  2. spotlessapply 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    7363dba View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. Fixed IRC dimension names 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    c31ee32 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Changes StatsHolder to originally store in a tree structure 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    e2a9536 View commit details
    Browse the repository at this point in the history

  2. Removed CacheStatsDimension 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    7dfe706 View commit details
    Browse the repository at this point in the history

  3. misc cleanup 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    30f90e9 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Addressed Ankit's comments 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    d208412 View commit details
    Browse the repository at this point in the history

  2. Fixed bug in StatsHolder.count() 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    c57fd95 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Misc simplifications 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    5483054 View commit details
    Browse the repository at this point in the history

  2. changelog 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    42c326b View commit details
    Browse the repository at this point in the history

  3. Added stats check when removing nodes 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    2ee05fe View commit details
    Browse the repository at this point in the history

  4. deserialization tweak 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    96c531d View commit details
    Browse the repository at this point in the history

  5. Made increment and removeDimension logic recursive 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    1119068 View commit details
    Browse the repository at this point in the history

  6. Separated out dimensionnode for the two classes, more recursive work 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    a7e6092 View commit details
    Browse the repository at this point in the history

  7. Misc cleanup 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    0474564 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Addressed minor comments 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    2ef1d2a View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. misc simplifications 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    5f9589a View commit details
    Browse the repository at this point in the history

  2. Addressed Ankit's synchronization + getter comments 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    ae936dc View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into tiramisu-stats-tiers

    Peter Alfonsi committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    de701ab View commit details
    Browse the repository at this point in the history

  4. fixed bug in populateStats + API annotations 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    a4e867d View commit details
    Browse the repository at this point in the history

  5. Added comments 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    c81254f View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. removed commented code 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    14f6488 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. cleanup 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    51523e3 View commit details
    Browse the repository at this point in the history

  2. Misc simplifications to MultiDimensionCacheStats 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    2d2e9b0 View commit details
    Browse the repository at this point in the history

  3. Moved stats removal tests to this PR 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    1e2273b View commit details
    Browse the repository at this point in the history

  4. Addressed Ankit's comments 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    93270f1 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Merge remote-tracking branch 'upstream/main' into tiramisu-stats-tiers

    Peter Alfonsi committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    13289d3 View commit details
    Browse the repository at this point in the history

  2. Made reading dimension node in MDCS recursive 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    93d53d5 View commit details
    Browse the repository at this point in the history

  3. Added javadocs for icachekeyserializer 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    fabb315 View commit details
    Browse the repository at this point in the history

  4. spotlessApply 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    2c7f431 View commit details
    Browse the repository at this point in the history

  5. Moved aggregation logic to API PR 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    fddd56e View commit details
    Browse the repository at this point in the history

  6. Moved some tests from MDCS to StatsHolderTests 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    c0c7b8e View commit details
    Browse the repository at this point in the history

  7. Removed serialization logic of MDCS from this PR 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    c96f474 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'upstream/main' into tiramisu-stats-tiers

    Peter Alfonsi committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    9c037e1 View commit details
    Browse the repository at this point in the history

  9. removed unnecessary fns from this pr 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    c0b3dd2 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Renamed classes to make more sense, removed interface 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    2f59ee7 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into tiramisu-stats-tiers

    Peter Alfonsi committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    da9e485 View commit details
    Browse the repository at this point in the history

  3. Renamed snapshot -> ImmutableCacheStats 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    f60fb08 View commit details
    Browse the repository at this point in the history

  4. Fixed flaky ehcache test 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    f465a22 View commit details
    Browse the repository at this point in the history

  5. Addressed Michael's comment 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    5283470 View commit details
    Browse the repository at this point in the history

  6. Improves code coverage 

    Signed-off-by: Peter Alfonsi <[email protected]>
    Peter Alfonsi committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    54e12a3 View commit details
    Browse the repository at this point in the history