Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] org.opensearch.common.xcontent.XContentParserTests.testString is flaky #12415

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Feb 21, 2024

Description

The YAML constraints apply to whole document, not just a value of particular key (and it is also in codepoints), it is difficult to get the limit exact, so relaxing constraints a bit.

Related Issues

Closes #12395

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added bug Something isn't working flaky-test Random test failure that succeeds on second run Other labels Feb 21, 2024
Copy link
Contributor

❌ Gradle check result for 00807dd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Feb 21, 2024

Compatibility status:

Checks if related components are compatible with change aeb1447

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

✅ Gradle check result for aeb1447: SUCCESS

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e97bee8) 71.47% compared to head (aeb1447) 71.37%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12415      +/-   ##
============================================
- Coverage     71.47%   71.37%   -0.10%     
+ Complexity    59938    59845      -93     
============================================
  Files          4972     4972              
  Lines        281770   281770              
  Branches      40910    40910              
============================================
- Hits         201385   201113     -272     
- Misses        63710    63954     +244     
- Partials      16675    16703      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❌ Gradle check result for c11aafa: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta merged commit bf050d4 into opensearch-project:main Feb 21, 2024
47 of 57 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Feb 21, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 21, 2024
…s flaky (#12415)

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit bf050d4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Feb 21, 2024
…s flaky (#12415) (#12418)

(cherry picked from commit bf050d4)

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
amkhar pushed a commit to amkhar/OpenSearch that referenced this pull request Mar 12, 2024
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working flaky-test Random test failure that succeeds on second run Other skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] org.opensearch.common.xcontent.XContentParserTests.testString is flaky
2 participants