-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch all the locks for a shard to avoid multiple remote store calls #11987
Fetch all the locks for a shard to avoid multiple remote store calls #11987
Conversation
Signed-off-by: Sachin Kale <[email protected]>
Compatibility status:Checks if related components are compatible with change 2381cb7 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/alerting.git] |
server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java
Show resolved
Hide resolved
❌ Gradle check result for e5a3d2b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good mostly, will re-review after UTs/ITs.
Signed-off-by: Sachin Kale <[email protected]>
❌ Gradle check result for 68bd634: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sachin Kale <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good .
server/src/main/java/org/opensearch/index/store/lockmanager/RemoteStoreMetadataLockManager.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for 9837f28: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sachin Kale <[email protected]>
❌ Gradle check result for 26fc4cd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 26fc4cd: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 26fc4cd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for 26fc4cd: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11987 +/- ##
============================================
+ Coverage 71.37% 71.40% +0.02%
- Complexity 59403 59408 +5
============================================
Files 4923 4923
Lines 279214 279218 +4
Branches 40596 40596
============================================
+ Hits 199302 199380 +78
+ Misses 63375 63218 -157
- Partials 16537 16620 +83 ☔ View full report in Codecov by Sentry. |
server/src/main/java/org/opensearch/index/store/lockmanager/RemoteStoreMetadataLockManager.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/index/store/RemoteSegmentStoreDirectoryTests.java
Show resolved
Hide resolved
Signed-off-by: Sachin Kale <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
❕ Gradle check result for 2381cb7: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
server/src/main/java/org/opensearch/index/store/lockmanager/RemoteStoreMetadataLockManager.java
Show resolved
Hide resolved
…11987) * Fetch all the locks for a shard to avoid multiple calls Signed-off-by: Sachin Kale <[email protected]> * Fix lock file comparison issue Signed-off-by: Sachin Kale <[email protected]> * Add unit tests Signed-off-by: Sachin Kale <[email protected]> * Add more unit tests Signed-off-by: Sachin Kale <[email protected]> * Address PR comments Signed-off-by: Sachin Kale <[email protected]> --------- Signed-off-by: Sachin Kale <[email protected]> Co-authored-by: Sachin Kale <[email protected]> (cherry picked from commit 6e744f5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…11987) (#12037) * Fetch all the locks for a shard to avoid multiple calls * Fix lock file comparison issue * Add unit tests * Add more unit tests * Address PR comments --------- (cherry picked from commit 6e744f5) Signed-off-by: Sachin Kale <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sachin Kale <[email protected]>
…pensearch-project#11987) * Fetch all the locks for a shard to avoid multiple calls Signed-off-by: Sachin Kale <[email protected]> * Fix lock file comparison issue Signed-off-by: Sachin Kale <[email protected]> * Add unit tests Signed-off-by: Sachin Kale <[email protected]> * Add more unit tests Signed-off-by: Sachin Kale <[email protected]> * Address PR comments Signed-off-by: Sachin Kale <[email protected]> --------- Signed-off-by: Sachin Kale <[email protected]> Co-authored-by: Sachin Kale <[email protected]>
…pensearch-project#11987) * Fetch all the locks for a shard to avoid multiple calls Signed-off-by: Sachin Kale <[email protected]> * Fix lock file comparison issue Signed-off-by: Sachin Kale <[email protected]> * Add unit tests Signed-off-by: Sachin Kale <[email protected]> * Add more unit tests Signed-off-by: Sachin Kale <[email protected]> * Address PR comments Signed-off-by: Sachin Kale <[email protected]> --------- Signed-off-by: Sachin Kale <[email protected]> Co-authored-by: Sachin Kale <[email protected]>
…pensearch-project#11987) * Fetch all the locks for a shard to avoid multiple calls Signed-off-by: Sachin Kale <[email protected]> * Fix lock file comparison issue Signed-off-by: Sachin Kale <[email protected]> * Add unit tests Signed-off-by: Sachin Kale <[email protected]> * Add more unit tests Signed-off-by: Sachin Kale <[email protected]> * Address PR comments Signed-off-by: Sachin Kale <[email protected]> --------- Signed-off-by: Sachin Kale <[email protected]> Co-authored-by: Sachin Kale <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Related Issues
Resolves #11409
Check List
New functionality has been documented.New functionality has javadoc addedFailing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)Commit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.