fix flaky test - handle IllegalStateException and throw AssertionError to use assertbusy

[linuxpi]

Description

• Fixes flaky test org.opensearch.remotestore.RemoteStoreClusterStateRestoreIT.testFullClusterRestoreGlobalMetadata
• We were not using assertBusy properly, handled IllegalStateException and throwing AssertionError

Related Issues

Resolves #10749

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Compatibility status:

Checks if related components are compatible with change 4a631f2

Incompatible components

Incompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/k-nn.git]

[github-actions]

❌ Gradle check result for b191308: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[linuxpi]

[Test Result](https://build.ci.opensearch.org/job/gradle-check/32483/testReport/) (1 failure / -8)

    [org.opensearch.ratelimitting.admissioncontrol.AdmissionControlMultiNodeIT.testAdmissionControlRejectionOnDisabled](https://build.ci.opensearch.org/job/gradle-check/32483/testReport/junit/org.opensearch.ratelimitting.admissioncontrol/AdmissionControlMultiNodeIT/testAdmissionControlRejectionOnDisabled/)

changes are unrelated to the failing test

[deshsidd]

LGTM. How many times have we run the test to test for flakiness fixed? Looks like a build is failing.

[linuxpi]

LGTM. How many times have we run the test to test for flakiness fixed? Looks like a build is failing.

Not able to repro after fix in 5k iterations. Retried the build

[github-actions]

✅ Gradle check result for 4a631f2: SUCCESS

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e265355) 71.41% compared to head (4a631f2) 71.46%.
Report is 20 commits behind head on main.

Files	Patch %	Lines
...g/opensearch/common/util/ReorganizingLongHash.java	60.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11981      +/-   ##
============================================
+ Coverage     71.41%   71.46%   +0.05%     
- Complexity    59397    59429      +32     
============================================
  Files          4923     4923              
  Lines        279212   279214       +2     
  Branches      40595    40596       +1     
============================================
+ Hits         199408   199552     +144     
+ Misses        63223    63040     -183     
- Partials      16581    16622      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.