Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix flaky RemoteStoreRefreshListenerTests testTrackerData #11256 #11902

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 517f091 from #11803.

Signed-off-by: Ashish Singh <[email protected]>
(cherry picked from commit 517f091)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 3dcd62a

Incompatible components

Incompatible components: [https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/k-nn.git]

Copy link
Contributor

❌ Gradle check result for 3dcd62a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@VachaShah VachaShah self-requested a review January 22, 2024 23:41
@VachaShah
Copy link
Collaborator

Gradle check failures:

[org.opensearch.search.sort.FieldSortIT.testSimpleSorts {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/32219/testReport/junit/org.opensearch.search.sort/FieldSortIT/testSimpleSorts__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterCommit](https://build.ci.opensearch.org/job/gradle-check/32219/testReport/junit/org.opensearch.index.shard/RemoteStoreRefreshListenerTests/testAfterCommit/)
[org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterMultipleCommits](https://build.ci.opensearch.org/job/gradle-check/32219/testReport/junit/org.opensearch.index.shard/RemoteStoreRefreshListenerTests/testAfterMultipleCommits/)
[org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterRefresh](https://build.ci.opensearch.org/job/gradle-check/32219/testReport/junit/org.opensearch.index.shard/RemoteStoreRefreshListenerTests/testAfterRefresh/)
[org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshAfterCommit](https://build.ci.opensearch.org/job/gradle-check/32219/testReport/junit/org.opensearch.index.shard/RemoteStoreRefreshListenerTests/testRefreshAfterCommit/)

@ashking94 Mind taking a look since the failures are from the same test class?

Copy link
Contributor

github-actions bot commented Feb 2, 2024

❌ Gradle check result for 3dcd62a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Feb 5, 2024

❕ Gradle check result for 3dcd62a: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.classMethod
      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testNonZeroPrimaryStatsOnNewlyCreatedIndexWithZeroDocs
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshAfterCommit
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterRefresh
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterRefresh
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterMultipleCommits
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testAfterCommit
      1 org.opensearch.index.shard.RemoteIndexShardTests.testNoFailuresOnFileReads

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@sachinpkale sachinpkale merged commit 52706da into 2.x Feb 5, 2024
56 of 83 checks passed
@github-actions github-actions bot deleted the backport/backport-11803-to-2.x branch February 5, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants