-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to more reliable OpenSearch Lucene snapshot location #11728
Conversation
- Related opensearch-project/opensearch-build#3874 Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]>
Compatibility status:Checks if related components are compatible with change 1a5be34 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git] |
❌ Gradle check result for 8bc6791: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@peternied thanks a lot, I believe other OS plugins use Gradle RepositoryPlugin (from build tools) and should get this change automatically, am I missing something (I see you created per-repository issues)? Thank you |
@reta Yes a majority of them do; however, I found hard coded instances in those repos - maybe they can delete them or maybe they should update the location🤷 |
❕ Gradle check result for 1a5be34: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11728 +/- ##
============================================
- Coverage 71.44% 71.41% -0.03%
+ Complexity 59267 59230 -37
============================================
Files 4909 4909
Lines 278427 278427
Branches 40460 40460
============================================
- Hits 198910 198841 -69
- Misses 63004 63072 +68
- Partials 16513 16514 +1 ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-11728-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 16d457d3f018893f6268a9ffa52d3d3f73f1a87a
# Push it to GitHub
git push --set-upstream origin backport/backport-11728-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
Apologies @peternied , could you please create manual backport to |
…ation (opensearch-project#11728) * Switched to more reliable OpenSearch Lucene snapshot location - Related opensearch-project/opensearch-build#3874 (cherry picked from commit 16d457d) Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]>
…ation (#11728) (#11729) * Switched to more reliable OpenSearch Lucene snapshot location - Related opensearch-project/opensearch-build#3874 (cherry picked from commit 16d457d) Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]>
- Related opensearch-project/opensearch-build#3874 - Related opensearch-project/OpenSearch#11728 Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> Co-authored-by: Owais Kazi <[email protected]>
- Related opensearch-project/opensearch-build#3874 - Related opensearch-project/OpenSearch#11728 Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> Co-authored-by: Owais Kazi <[email protected]> (cherry picked from commit 95f0eaf) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
) - Related opensearch-project/opensearch-build#3874 - Related opensearch-project/OpenSearch#11728 (cherry picked from commit 95f0eaf) Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Owais Kazi <[email protected]> Co-authored-by: Sarat Vemulapalli <[email protected]>
Issues: - Driver of this change opensearch-project/opensearch-build#3874 (comment) - Previous change updated the wrong location opensearch-project#11728 Signed-off-by: Peter Nied <[email protected]>
…ch-project#11728) * Switched to more reliable OpenSearch Lucene snapshot location - Related opensearch-project/opensearch-build#3874 Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> * Changelog entry Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> --------- Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]>
…ch-project#11728) * Switched to more reliable OpenSearch Lucene snapshot location - Related opensearch-project/opensearch-build#3874 Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> * Changelog entry Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> --------- Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Switched to more reliable OpenSearch Lucene snapshot location
Related Issues
Check List
New functionality includes testing.All tests passNew functionality has been documented.New functionality has javadoc addedPublic documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.