-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for dynamically adding SearchRequestOperationsListener #11526
Add support for dynamically adding SearchRequestOperationsListener #11526
Conversation
❌ Gradle check result for d4e323f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
79caa4f
to
0386fe5
Compare
❕ Gradle check result for 79caa4f: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
❕ Gradle check result for 0386fe5: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for promptly addressing the review comments!
Signed-off-by: Chenyang Ji <[email protected]>
…ListenerManager Signed-off-by: Chenyang Ji <[email protected]>
Signed-off-by: Chenyang Ji <[email protected]>
Signed-off-by: Chenyang Ji <[email protected]>
Signed-off-by: Chenyang Ji <[email protected]>
Signed-off-by: Chenyang Ji <[email protected]>
0386fe5
to
5d407b3
Compare
…rationsCompositeListenerFactory Signed-off-by: Chenyang Ji <[email protected]>
5d407b3
to
96c8388
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks @ansjcy for all the code cleanup in this change
❕ Gradle check result for 5d407b3: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-11526-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6aab36052055e24c2ef56454da9d3a1e4982ee6e
# Push it to GitHub
git push --set-upstream origin backport/backport-11526-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…h-project#11526) Along the way, also refactored TransportSearchAction.TimeProvider, so that it's no longer a (redundant) listener. --------- Signed-off-by: Chenyang Ji <[email protected]> (cherry picked from commit 6aab360)
…ener (#11526) (#12192) * Support dynamically adding SearchRequestOperationsListener (#11526) Along the way, also refactored TransportSearchAction.TimeProvider, so that it's no longer a (redundant) listener. --------- Signed-off-by: Chenyang Ji <[email protected]> (cherry picked from commit 6aab360) * fix compilation error Signed-off-by: Chenyang Ji <[email protected]> --------- Signed-off-by: Chenyang Ji <[email protected]>
…h-project#11526) Along the way, also refactored TransportSearchAction.TimeProvider, so that it's no longer a (redundant) listener. --------- Signed-off-by: Chenyang Ji <[email protected]>
…h-project#11526) Along the way, also refactored TransportSearchAction.TimeProvider, so that it's no longer a (redundant) listener. --------- Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Adding support for dynamically creating and registering SearchRequestOperationsListener from other components, and refactored the current code to move the logic related to "adding cluster-level operations listeners" away from the core search path.
This PR will support adding new listeners from other components/workflows/plugins without cluttering the core search path.
Related Issues
Resolves #11520 #11762
Tests
phaseTook
disabledphaseTook
enabled on the request levelphaseTook
on the cluster level, run the search request again.result:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.