-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky test in CardinalityWithRequestBreakerIT #11513
Conversation
Compatibility status:Checks if related components are compatible with change 0bc6656 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11513 +/- ##
============================================
- Coverage 71.40% 71.23% -0.17%
+ Complexity 59146 59088 -58
============================================
Files 4904 4904
Lines 278149 278149
Branches 40419 40419
============================================
- Hits 198599 198134 -465
- Misses 63020 63530 +510
+ Partials 16530 16485 -45 ☔ View full report in Codecov by Sentry. |
...java/org/opensearch/search/aggregations/ConcurrentSearchCardinalityWithRequestBreakerIT.java
Outdated
Show resolved
Hide resolved
...java/org/opensearch/search/aggregations/ConcurrentSearchCardinalityWithRequestBreakerIT.java
Show resolved
Hide resolved
...terTest/java/org/opensearch/search/aggregations/metrics/CardinalityWithRequestBreakerIT.java
Show resolved
Hide resolved
...java/org/opensearch/search/aggregations/ConcurrentSearchCardinalityWithRequestBreakerIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Neetika Singhal <[email protected]>
956b000
to
0bc6656
Compare
...java/org/opensearch/search/aggregations/ConcurrentSearchCardinalityWithRequestBreakerIT.java
Show resolved
Hide resolved
❌ Gradle check result for 0bc6656: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
this doesnt look to be the right solution either, will close this pr |
Description
Creating a separate class for Concurrent Search use-case as parameterization doesn't work with Circuit Breaker causing flaky tests.
Related Issues
Resolves #10154
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.