-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically add scheme to discovery.ec2.endpoint #11512
Conversation
Compatibility status:Checks if related components are compatible with change 15f4d5c Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/sql.git] |
Signed-off-by: Yanlong He <[email protected]>
❌ Gradle check result for 12ba28d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Yanlong He <[email protected]>
❌ Gradle check result for 8af6efc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Yanlong He <[email protected]>
❕ Gradle check result for bbbb93f: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Yanlong He <[email protected]>
Signed-off-by: Yanlong He <[email protected]>
Signed-off-by: 何延龙 <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-11512-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a8da66caa173c27f98c2124e012d372c64183d6d
# Push it to GitHub
git push --set-upstream origin backport/backport-11512-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
@heyanlong could you please manually backport this change for the 2.x release following the guide above? |
…t#11512) Signed-off-by: Yanlong He <[email protected]> Signed-off-by: 何延龙 <[email protected]> (cherry picked from commit a8da66c)
…t#11512) Signed-off-by: Yanlong He <[email protected]> Signed-off-by: 何延龙 <[email protected]> (cherry picked from commit a8da66c)
…1512) (#11603) Signed-off-by: Yanlong He <[email protected]> Signed-off-by: 何延龙 <[email protected]> (cherry picked from commit a8da66c)
@heyanlong This won't work if my endpoint is |
…t#11512) Signed-off-by: Yanlong He <[email protected]> Signed-off-by: 何延龙 <[email protected]>
…t#11512) Signed-off-by: Yanlong He <[email protected]> Signed-off-by: 何延龙 <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Fix the problem that
discovery.ec2.endpoint
forgets to fill in the schemehttps://docs.aws.amazon.com/general/latest/gr/rande.html#ec2_region
Example
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.