Adding support to run BWC tests for nightly and release builds

[saratvemulapalli]

Signed-off-by: Sarat Vemulapalli [email protected]

Description

Adding support to run BWC tests for nightly and release builds via test pipeline.
Refer to: opensearch-project/opensearch-build#90

Issues Resolved

opensearch-project/opensearch-build#296

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[opensearch-ci-bot]

✅   DCO Check Passed 74f7ddd

[opensearch-ci-bot]

✅   Gradle Wrapper Validation success 74f7ddd

[opensearch-ci-bot]

✅   Gradle Precommit success 74f7ddd

[VachaShah]

LGTM, thank you @saratvemulapalli for the change!

[saratvemulapalli]

start gradle check

[opensearch-ci-bot]

❌   Gradle Check failure 74f7ddd
Log 421

Reports 421

[saratvemulapalli]

start gradle check

[opensearch-ci-bot]

❌   Gradle Check failure 74f7ddd
Log 424

Reports 424

[saratvemulapalli]

Some how bwc checks are failing

* What went wrong:
Execution failed for task ':distribution:bwc:minor:buildBwcLinuxTar'.
> Building 1.0.0 didn't generate expected file /var/CITOOL/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/search/distribution/bwc/minor/build/bwc/checkout-1.0/distribution/archives/linux-tar/build/distributions/opensearch-1.0.0-SNAPSHOT-linux-x64.tar.gz

[tlfeng]

start gradle check

[tlfeng]

See more detail of the BWC test failure: #1158

[opensearch-ci-bot]

❌   Gradle Check failure 74f7ddd
Log 434

Reports 434

[tlfeng]

Hey Sarat, in my PR, the gradle check passed after I merged the current main branch to my branch (#1153 (comment)), so you could try the same.

[saratvemulapalli]

Hey Sarat, in my PR, the gradle check passed after I merged the current main branch to my branch (#1153 (comment)), so you could try the same.

Thanks Tianli!
I left the PR open because the runner is not merged yet. But thanks for this.

[saratvemulapalli]

start gradle check

[opensearch-ci-bot]

❌   Gradle Check failure 74f7ddd
Log 463

Reports 463

[dblock]

Should this be a default implementation in the calling code, so we wouldn't have to check in a copy of this in all projects?

[saratvemulapalli]

Should this be a default implementation in the calling code, so we wouldn't have to check in a copy of this in all projects?

Good question. Let me know your thoughts.
The thought process is that the bwctest.sh file will define all the bwc tests the repository needs. And each repo/branch could configure it to run with few/all the tests if they need. This file enables that configuration.

That said we have 2 options:

1. Have all repositories define bwctest.sh, make it unambiguous for any body to hook up to bwc testing.
2. Define a default mechanism that would be called like (./gradlew bwctest) and any repository who wishes to have it custom they could define bwctest.sh.

I am leaning towards 1 (for the short term):

• Its clear for repository owners and no magic involved.
• While repositories are onboarding to bwctest infra, we can update the test_workflow to have a default implementation.
• Eventually we could move to 2. and add documentation for owners.

[opensearch-ci-bot]

✅   Gradle Wrapper Validation success 8a2ed95b6c2883d708251ba66bbb76d20dc1c703

[opensearch-ci-bot]

❌   DCO Check Failed 8a2ed95b6c2883d708251ba66bbb76d20dc1c703
Run ./dev-tools/signoff-check.sh remotes/origin/main 8a2ed95b6c2883d708251ba66bbb76d20dc1c703 to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

[opensearch-ci-bot]

✅   Gradle Wrapper Validation success 7d8ae8d

[opensearch-ci-bot]

✅   DCO Check Passed 7d8ae8d

[opensearch-ci-bot]

✅   Gradle Precommit success 8a2ed95b6c2883d708251ba66bbb76d20dc1c703

[saratvemulapalli]

start gradle check

[opensearch-ci-bot]

✅   Gradle Precommit success 7d8ae8d

[opensearch-ci-bot]

✅   Gradle Check success 7d8ae8d
Log 495

Reports 495

[dblock]

Why do we need a custom .sh script that just calls gradle? Shouldn't this be the default for any Gradle project coming from opensearch-build?

[saratvemulapalli]

Closing this PR.
Had a chat with @dblock , It makes sense to have a default bwctest.sh script in opensearch-build.