Revert Rounding API visibility changes

[reta]

Description

Follow up on #11083

Related Issues

N/A

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Compatibility status:

Checks if related components are compatible with change 42f12fb

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/sql.git]

[github-actions]

❌ Gradle check result for 998db2a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[jainankitk]

LGTM, approved!

[github-actions]

❕ Gradle check result for 42f12fb: UNSTABLE

• TEST FAILURES:

      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (6bc0cd6) 71.33% compared to head (42f12fb) 71.37%.

Files	Patch %	Lines
.../src/main/java/org/opensearch/common/Rounding.java	66.66%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11392      +/-   ##
============================================
+ Coverage     71.33%   71.37%   +0.03%     
- Complexity    59018    59074      +56     
============================================
  Files          4891     4891              
  Lines        277644   277646       +2     
  Branches      40343    40345       +2     
============================================
+ Hits         198058   198160     +102     
+ Misses        63084    63052      -32     
+ Partials      16502    16434      -68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-11392-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 50e3666414b7f73c40f41960177e8098071550b9
# Push it to GitHub
git push --set-upstream origin backport/backport-11392-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-11392-to-2.x.

[msfroh]

The backport to 2.x failed:

@reta -- I was thinking of asking @jainankitk to incorporate / apply this commit on top of #11390.

Essentially, while main has the date histogram change including changing the Rounding method visibility changes followed by this change to revert the visibility changes, I'm thinking that the backport of the date histogram change could do so without the visibility change (i.e. pretend like the mistake never happened on 2.x).

Or should we "replay" the mistake and the fix on 2.x too? I'm happy to go either way.

[reta]

@reta -- I was thinking of asking @jainankitk to incorporate / apply this commit on top of #11390.

I had exactly the same idea, thanks @msfroh , I will ask @jainankitk