-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update error message when lucene max document limit is breached #11312
Conversation
Compatibility status:Checks if related components are compatible with change 3b842e4 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git] |
❌ Gradle check result for 8ba742f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/index/engine/InternalEngine.java
Outdated
Show resolved
Hide resolved
46e23de
to
0fb001d
Compare
❕ Gradle check result for 0fb001d: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
server/src/main/java/org/opensearch/index/engine/InternalEngine.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Shreyansh Ray <[email protected]>
0fb001d
to
eb6639a
Compare
❌ Gradle check result for eb6639a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Shreyansh Ray <[email protected]>
eb6639a
to
3b842e4
Compare
❕ Gradle check result for 3b842e4: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
@reta good? |
@mgodwan LGTM? |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-11312-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 25cb920081cba4a431040511c71a7355393f2b3a
# Push it to GitHub
git push --set-upstream origin backport/backport-11312-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
@rayshrey you'll unfortunately need to manually backport to 2.x if you want this in the next 2.x release |
…search-project#11312) * Update error message when lucene document limit is breached Signed-off-by: Shreyansh Ray <[email protected]> * Update error message as per review comments Signed-off-by: Shreyansh Ray <[email protected]> --------- Signed-off-by: Shreyansh Ray <[email protected]>
…) (#11382) * Update error message when lucene document limit is breached * Update error message as per review comments --------- Signed-off-by: Shreyansh Ray <[email protected]>
…search-project#11312) * Update error message when lucene document limit is breached Signed-off-by: Shreyansh Ray <[email protected]> * Update error message as per review comments Signed-off-by: Shreyansh Ray <[email protected]> --------- Signed-off-by: Shreyansh Ray <[email protected]>
…search-project#11312) * Update error message when lucene document limit is breached Signed-off-by: Shreyansh Ray <[email protected]> * Update error message as per review comments Signed-off-by: Shreyansh Ray <[email protected]> --------- Signed-off-by: Shreyansh Ray <[email protected]>
…search-project#11312) * Update error message when lucene document limit is breached Signed-off-by: Shreyansh Ray <[email protected]> * Update error message as per review comments Signed-off-by: Shreyansh Ray <[email protected]> --------- Signed-off-by: Shreyansh Ray <[email protected]>
…search-project#11312) * Update error message when lucene document limit is breached Signed-off-by: Shreyansh Ray <[email protected]> * Update error message as per review comments Signed-off-by: Shreyansh Ray <[email protected]> --------- Signed-off-by: Shreyansh Ray <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Whenever lucene document limit(which is currently INT_MAX) is breached for any shard, the error message that is shown currently indicates that the limit is on an index level whereas actually the limit is on a shard level.
Updating the error message in this PR to indicate the same. Also including the Shard Id as well in the message.
Previous message
Updated message
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
New functionality includes testing.All tests passNew functionality has been documented.New functionality has javadoc addedFailing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.