Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error message when lucene max document limit is breached #11312

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

rayshrey
Copy link
Contributor

@rayshrey rayshrey commented Nov 23, 2023

Description

Whenever lucene document limit(which is currently INT_MAX) is breached for any shard, the error message that is shown currently indicates that the limit is on an index level whereas actually the limit is on a shard level.

Updating the error message in this PR to indicate the same. Also including the Shard Id as well in the message.

Previous message

Number of documents in the index can't exceed [2147483647]

Updated message

Number of documents in shard <index_name>[<shardId>] exceeds the limit of [2147483647] documents per shard

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Nov 23, 2023

Compatibility status:

Checks if related components are compatible with change 3b842e4

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

❌ Gradle check result for 8ba742f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 0fb001d: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

❌ Gradle check result for eb6639a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 3b842e4: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@dblock
Copy link
Member

dblock commented Nov 28, 2023

@reta good?

@reta
Copy link
Collaborator

reta commented Nov 28, 2023

@mgodwan LGTM?

@dblock dblock merged commit 25cb920 into opensearch-project:main Nov 28, 2023
29 checks passed
@dblock dblock added the backport 2.x Backport to 2.x branch label Nov 28, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-11312-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 25cb920081cba4a431040511c71a7355393f2b3a
# Push it to GitHub
git push --set-upstream origin backport/backport-11312-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-11312-to-2.x.

@dblock
Copy link
Member

dblock commented Nov 28, 2023

@rayshrey you'll unfortunately need to manually backport to 2.x if you want this in the next 2.x release

rayshrey added a commit to rayshrey/OpenSearch that referenced this pull request Nov 29, 2023
…search-project#11312)

* Update error message when lucene document limit is breached

Signed-off-by: Shreyansh Ray <[email protected]>

* Update error message as per review comments

Signed-off-by: Shreyansh Ray <[email protected]>

---------

Signed-off-by: Shreyansh Ray <[email protected]>
@rayshrey
Copy link
Contributor Author

@dblock raised the manual backport here - #11382

reta pushed a commit that referenced this pull request Nov 29, 2023
…) (#11382)

* Update error message when lucene document limit is breached



* Update error message as per review comments



---------

Signed-off-by: Shreyansh Ray <[email protected]>
@reta reta added the v3.0.0 Issues and PRs related to version 3.0.0 label Nov 29, 2023
fahadshamiinsta pushed a commit to fahadshamiinsta/OpenSearch270 that referenced this pull request Dec 4, 2023
…search-project#11312)

* Update error message when lucene document limit is breached

Signed-off-by: Shreyansh Ray <[email protected]>

* Update error message as per review comments

Signed-off-by: Shreyansh Ray <[email protected]>

---------

Signed-off-by: Shreyansh Ray <[email protected]>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Dec 11, 2023
…search-project#11312)

* Update error message when lucene document limit is breached

Signed-off-by: Shreyansh Ray <[email protected]>

* Update error message as per review comments

Signed-off-by: Shreyansh Ray <[email protected]>

---------

Signed-off-by: Shreyansh Ray <[email protected]>
rayshrey added a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
…search-project#11312)

* Update error message when lucene document limit is breached

Signed-off-by: Shreyansh Ray <[email protected]>

* Update error message as per review comments

Signed-off-by: Shreyansh Ray <[email protected]>

---------

Signed-off-by: Shreyansh Ray <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…search-project#11312)

* Update error message when lucene document limit is breached

Signed-off-by: Shreyansh Ray <[email protected]>

* Update error message as per review comments

Signed-off-by: Shreyansh Ray <[email protected]>

---------

Signed-off-by: Shreyansh Ray <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants