-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Disallow removing some metadata fields by remove ingest processor #11311
[Backport 2.x] Disallow removing some metadata fields by remove ingest processor #11311
Conversation
…ensearch-project#10895) * Ignore metadata fields when removing fields by remove ingest processor Signed-off-by: Gao Binlong <[email protected]> * Modify change log Signed-off-by: Gao Binlong <[email protected]> * Throw exception when removing some metadata fields Signed-off-by: Gao Binlong <[email protected]> * Format the code Signed-off-by: Gao Binlong <[email protected]> * Remove calling toLowerCase() Signed-off-by: Gao Binlong <[email protected]> * Remove calling toLowerCase() Signed-off-by: Gao Binlong <[email protected]> * Fix test failure Signed-off-by: Gao Binlong <[email protected]> * Add skip config in yml test file Signed-off-by: Gao Binlong <[email protected]> * Improve test coverage Signed-off-by: Gao Binlong <[email protected]> * Optimize some code Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> (cherry picked from commit a0b016b)
Signed-off-by: Gao Binlong <[email protected]>
Compatibility status:Checks if related components are compatible with change fe42a5a Incompatible componentsIncompatible components: [https://github.com/opensearch-project/performance-analyzer.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/sql.git] |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #11311 +/- ##
============================================
- Coverage 71.15% 70.96% -0.19%
+ Complexity 59161 59059 -102
============================================
Files 4869 4869
Lines 278660 278669 +9
Branches 40831 40836 +5
============================================
- Hits 198271 197755 -516
- Misses 63605 64171 +566
+ Partials 16784 16743 -41 ☔ View full report in Codecov by Sentry. |
❌ Gradle check result for fb1a7c6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Flaky test: #11032. |
❕ Gradle check result for fb1a7c6: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Description
Backport #10895.
Related Issues
#10732
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.