Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for concurrent search #11117

Closed
wants to merge 0 commits into from
Closed

Fix tests for concurrent search #11117

wants to merge 0 commits into from

Conversation

Gankris96
Copy link
Contributor

@Gankris96 Gankris96 commented Nov 6, 2023 •
edited
Loading

Description

This change ensures that the indexRandomForConcurrentSearch function, that is used to create more segments for concurrent search tests is invoked from the tests within this PR to test concurrent search use-cases where multiple slices are created based on segment count.
The change affects the following tests -

MetadataFetchingIT.java
SortFromPluginIT.java
SuggestSearchIT.java
SourceFetchingIT.testSourceDefaultBehavior
GeoDistanceIT.testGeoDistanceFilter
FieldSortIT.testTrackScores
SearchScrollIT.testScrollRewrittenToMatchNoDocs

Related Issues

#10247

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change 0ba5d58

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/sql.git]

@Gankris96 Gankris96 marked this pull request as ready for review November 6, 2023 23:34
@jed326
Copy link
Collaborator

jed326 commented Nov 6, 2023

@Gankris96 can you you signoff your commit & check the spotless failure?
For ex.
git commit --amend --signoff --author="Jay Deng <email>" --date=now
./gradlew :server:spotlessApply (ref: https://build.ci.opensearch.org/job/gradle-check/29631/consoleText)

@Gankris96 Gankris96 requested a review from tlfeng as a code owner November 6, 2023 23:45
neetikasinghal
neetikasinghal reviewed Nov 6, 2023
View reviewed changes
server/src/internalClusterTest/java/org/opensearch/search/scroll/SearchScrollIT.java Outdated
@@ -746,6 +746,7 @@ public void testScrollRewrittenToMatchNoDocs() {
client().prepareIndex("test").setId("2").setSource("created_date", "2020-01-02").get();
client().prepareIndex("test").setId("3").setSource("created_date", "2020-01-03").get();
client().admin().indices().prepareRefresh("test").get();
indexRandomForConcurrentSearch( "test");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove extra space

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Gradle Check (Jenkins) Run Completed with:

@neetikasinghal neetikasinghal mentioned this pull request Nov 6, 2023
Closed
5 tasks
@neetikasinghal
Copy link
Contributor

Run ./gradlew :server:spotlessApply to fix the gradle check failures

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

@Gankris96 Gankris96 closed this Nov 7, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neetikasinghal neetikasinghal neetikasinghal left review comments

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz

@andrross andrross Awaiting requested review from andrross

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal

@mch2 mch2 Awaiting requested review from mch2

@msfroh msfroh Awaiting requested review from msfroh

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19

@peternied peternied Awaiting requested review from peternied

@reta reta Awaiting requested review from reta

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli

@setiah setiah Awaiting requested review from setiah

@shwetathareja shwetathareja Awaiting requested review from shwetathareja

@sohami sohami Awaiting requested review from sohami

@VachaShah VachaShah Awaiting requested review from VachaShah

@tlfeng tlfeng Awaiting requested review from tlfeng

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gankris96 @jed326 @neetikasinghal @ticheng-aws