-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable sort optimization for HALF_FLOAT #10999
Conversation
@reta need your quick review here :) , just got one nasty bug with |
Signed-off-by: Chaitanya Gohel <[email protected]>
Compatibility status:Checks if related components are compatible with change 950d89b Incompatible componentsIncompatible components: [https://github.com/opensearch-project/performance-analyzer.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git] |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #10999 +/- ##
============================================
+ Coverage 71.21% 71.32% +0.10%
- Complexity 58650 58802 +152
============================================
Files 4870 4870
Lines 276610 276610
Branches 40206 40206
============================================
+ Hits 196984 197281 +297
+ Misses 63194 62897 -297
Partials 16432 16432
|
Signed-off-by: Chaitanya Gohel <[email protected]> (cherry picked from commit 448635f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.11 2.11
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.11
# Create a new branch
git switch --create backport/backport-10999-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 448635f77855108afedfe6f2e5c07a2f6c37746c
# Push it to GitHub
git push --set-upstream origin backport/backport-10999-to-2.11
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.11 Then, create a pull request where the |
Signed-off-by: Chaitanya Gohel <[email protected]>
Signed-off-by: Chaitanya Gohel <[email protected]>
(cherry picked from commit 448635f) Signed-off-by: Chaitanya Gohel <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Chaitanya Gohel <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Fixing - > #10997.
Disable point based sort optimization for half_flaot.
There is a way we can enable it back but it needs bigger code change and I will send out shortly. We will have to create HalfFloatNumericSourceComparator as well HafFloatComparator same as we did for
unsigned_long
for that.Created follow up issue here to make it back.
#10998
Check List